-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(primitives): Remove Attributes #529
Conversation
This stack of pull requests is managed by Graphite. Learn more about stacking. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, but I'd prefer if we changed OptimismPayloadAttributes
to not have Option
s for transactions
, no_tx_pool
. These should always be there, since the type is not intended to be backwards-compat w/ L1 payload attributes.
They're all marked Do you want to diverge from this for any specific reason? |
b1ef0f9
to
aa69a8d
Compare
Description
Removes the
attributes
module fromkona-primitives
, re-using payload attributes types defined inalloy-rpc-types-engine
andop-alloy-rpc-types-engine
.Closes #510