Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(preimage): Async client traits #200

Merged
merged 1 commit into from
Jun 3, 2024
Merged

feat(preimage): Async client traits #200

merged 1 commit into from
Jun 3, 2024

Commits on Jun 2, 2024

  1. feat(preimage): Async client handles

    Makes the `HintWriterClient` + `PreimageOracleClient` traits
    asynchronous to prevent blocking of the host program when executing a
    client program natively.
    
    Previously, since the preimage oracle bindings for the client were
    entirely synchronous, the loops in `PipeHandle` could cause a deadlock.
    Now that oracle IO is asynchronous, the runtime can interrupt a future
    when it yields execution (i.e. `tokio::select` works.)
    
    In the client program, synchronous execution is still guaranteed. It can
    run async colored functions in a minimal runtime, such as the `block_on`
    runtime in `kona_common`. `simple-revm` had to be changed as a part of
    this PR, which has an example of this.
    clabby committed Jun 2, 2024
    Configuration menu
    Copy the full SHA
    512031f View commit details
    Browse the repository at this point in the history