-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(derive): Refactor out Online Providers #569
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This stack of pull requests is managed by Graphite. Learn more about stacking. |
refcell
changed the title
feat(derive): refactor out online providers
feat(derive): Refactor out online providers
Sep 24, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files☔ View full report in Codecov by Sentry. |
refcell
added
A-derive
Area: kona-derive crate
K-feature
Kind: feature
labels
Sep 24, 2024
— with
Graphite App
refcell
force-pushed
the
rf/feat/kona-providers
branch
2 times, most recently
from
September 25, 2024 00:50
716c6e4
to
638d2bb
Compare
refcell
changed the title
feat(derive): Refactor out online providers
feat(derive): Refactor out Online Providers
Sep 25, 2024
refcell
force-pushed
the
rf/feat/kona-providers
branch
from
September 30, 2024 17:41
638d2bb
to
83a3ad4
Compare
refcell
force-pushed
the
rf/feat/kona-providers
branch
from
September 30, 2024 17:41
83a3ad4
to
790b340
Compare
clabby
approved these changes
Sep 30, 2024
This was referenced Sep 30, 2024
Closed
Closed
Closed
Closed
This was referenced Oct 7, 2024
Closed
Closed
Closed
This was referenced Oct 9, 2024
Closed
Closed
Closed
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Refactors out online providers into a new
kona-providers-alloy
crate.This reduces the online periphery complexity in
kona-derive
allowing it to have less dependencies and easier feature management.