Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(derive): Hoist AttributesBuilder #571

Merged
merged 2 commits into from
Sep 25, 2024
Merged

feat(derive): Hoist AttributesBuilder #571

merged 2 commits into from
Sep 25, 2024

Conversation

refcell
Copy link
Collaborator

@refcell refcell commented Sep 25, 2024 •
edited
Loading

Description

Hoists the AttributesBuilder to flatten modules within stages.

@refcell Graphite App
Copy link
Collaborator Author

refcell commented Sep 25, 2024 •
edited
Loading

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @refcell and the rest of your teammates on Graphite Graphite

@refcell refcell mentioned this pull request Sep 25, 2024
Merged
@refcell refcell changed the title fix: hoist attributes builder fix(derive): Hoist AttributesBuilder Sep 25, 2024
@refcell refcell requested a review from clabby September 25, 2024 00:20
@refcell refcell added A-derive Area: kona-derive crate K-chore Kind: chore labels Sep 25, 2024 — with Graphite App
@refcell refcell changed the title fix(derive): Hoist AttributesBuilder feat(derive): Hoist AttributesBuilder Sep 25, 2024
@refcell refcell marked this pull request as ready for review September 25, 2024 00:21
@refcell refcell self-assigned this Sep 25, 2024
@codecov Codecov
Copy link

codecov bot commented Sep 25, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 99.09091% with 1 line in your changes missing coverage. Please review.

Project coverage is 78.6%. Comparing base (0b54700) to head (b2b210e).
Report is 1 commits behind head on main.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
crates/derive/src/attributes/mod.rs 99.0% 1 Missing ⚠️
Additional details and impacted files

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

clabby
clabby approved these changes Sep 25, 2024
View reviewed changes
Copy link
Collaborator

@clabby clabby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

muy bien

@refcell refcell force-pushed the rf/feat/attributes-builder-hoist branch from 463226e to 1dab12b Compare September 25, 2024 22:19
@refcell refcell changed the base branch from rf/feat/attributes-builder-trait to main September 25, 2024 22:19
@refcell refcell enabled auto-merge September 25, 2024 22:20
@refcell refcell added this pull request to the merge queue Sep 25, 2024
Merged via the queue into main with commit b2f114a Sep 25, 2024
17 checks passed
This was referenced Sep 25, 2024
Closed
Closed
This was referenced Oct 3, 2024
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
@github-actions github-actions bot mentioned this pull request Oct 13, 2024
Closed
@github-actions github-actions bot mentioned this pull request Oct 19, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@clabby clabby clabby approved these changes

Assignees

@refcell refcell

Labels
A-derive Area: kona-derive crate K-chore Kind: chore
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@refcell @clabby