Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(derive): Hoist AttributesBuilder Trait #570

Merged
merged 1 commit into from
Sep 25, 2024

Conversation

refcell
Copy link
Collaborator

@refcell refcell commented Sep 24, 2024

Description

Hoists the AttributesBuilder trait to allow the attributes builder to be moved easier in up-stack prs.

Copy link
Collaborator Author

refcell commented Sep 24, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @refcell and the rest of your teammates on Graphite Graphite

Copy link

codecov bot commented Sep 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.6%. Comparing base (830a828) to head (32a59dd).
Report is 1 commits behind head on main.

✅ All tests successful. No failed tests found.

Additional details and impacted files

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@refcell refcell changed the title fix(derive): move attributes builder trait fix(derive): Hoist AttributesBuilder Trait Sep 25, 2024
@refcell refcell requested a review from clabby September 25, 2024 00:08
@refcell refcell added A-derive Area: kona-derive crate K-chore Kind: chore labels Sep 25, 2024 — with Graphite App
@refcell refcell marked this pull request as ready for review September 25, 2024 00:08
@refcell refcell self-assigned this Sep 25, 2024
@refcell refcell added this pull request to the merge queue Sep 25, 2024
Merged via the queue into main with commit 0b54700 Sep 25, 2024
17 checks passed
This was referenced Sep 25, 2024
This was referenced Oct 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-derive Area: kona-derive crate K-chore Kind: chore
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants