Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: kona-providers #596

Merged
merged 4 commits into from
Oct 2, 2024
Merged

feat: kona-providers #596

merged 4 commits into from
Oct 2, 2024

Conversation

refcell
Copy link
Collaborator

@refcell refcell commented Oct 1, 2024

Description

Splits out provider traits from kona-derive into a new minimal crate that can be implemented by various provider implementation crates like kona-providers-alloy.

Also bumps alloy and op-alloy dependencies to use upstream block types.

Copy link
Collaborator Author

refcell commented Oct 1, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @refcell and the rest of your teammates on Graphite Graphite

@refcell refcell changed the title stash: kona-providers feat: kona-providers Oct 1, 2024
@refcell refcell requested a review from clabby October 1, 2024 00:14
@refcell refcell added A-derive Area: kona-derive crate A-workspace Area: Top level workspace modifications K-feature Kind: feature labels Oct 1, 2024 — with Graphite App
@refcell refcell marked this pull request as ready for review October 1, 2024 00:14
@refcell refcell marked this pull request as draft October 1, 2024 00:19
@refcell refcell marked this pull request as draft October 1, 2024 00:19
@refcell refcell marked this pull request as draft October 1, 2024 00:19
@refcell refcell marked this pull request as draft October 1, 2024 00:19
@refcell refcell marked this pull request as draft October 1, 2024 00:19
@refcell refcell marked this pull request as draft October 1, 2024 00:19
@refcell refcell marked this pull request as draft October 1, 2024 00:19
@refcell refcell marked this pull request as draft October 1, 2024 00:19
@refcell refcell marked this pull request as draft October 1, 2024 00:19
@refcell refcell marked this pull request as draft October 1, 2024 00:19
@refcell refcell marked this pull request as draft October 1, 2024 00:19
@refcell refcell self-assigned this Oct 1, 2024
@refcell refcell marked this pull request as ready for review October 1, 2024 01:27
crates/providers/src/utils.rs Outdated Show resolved Hide resolved
Copy link

codecov bot commented Oct 1, 2024

Codecov Report

Attention: Patch coverage is 56.09756% with 72 lines in your changes missing coverage. Please review.

Project coverage is 80.0%. Comparing base (ed6f8f9) to head (a31d458).
Report is 3 commits behind head on main.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
crates/providers/src/utils.rs 0.0% 45 Missing ⚠️
crates/providers-alloy/src/alloy_providers.rs 0.0% 14 Missing ⚠️
crates/derive/src/attributes/mod.rs 0.0% 5 Missing ⚠️
crates/derive/src/batch/span_batch/batch.rs 88.5% 4 Missing ⚠️
crates/executor/src/util.rs 60.0% 2 Missing ⚠️
crates/derive/src/batch/span_batch/transactions.rs 0.0% 1 Missing ⚠️
crates/executor/src/lib.rs 95.4% 1 Missing ⚠️
Additional details and impacted files

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

crates/derive/src/attributes/mod.rs Show resolved Hide resolved
crates/derive/src/batch/span_batch/batch.rs Outdated Show resolved Hide resolved
@refcell refcell enabled auto-merge October 2, 2024 14:06
@refcell refcell added this pull request to the merge queue Oct 2, 2024
Merged via the queue into main with commit 172d7b2 Oct 2, 2024
16 of 18 checks passed
@github-actions github-actions bot mentioned this pull request Oct 2, 2024
This was referenced Oct 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-derive Area: kona-derive crate A-workspace Area: Top level workspace modifications K-feature Kind: feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants