Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(executor): Holocene EIP-1559 params in Header #622

Merged
merged 6 commits into from
Oct 4, 2024
Merged

Conversation

clabby
Copy link
Collaborator

@clabby clabby commented Oct 4, 2024

Overview

Fixes the inclusion of the current block's base fee parameters within the Header. As-is, it always includes the payload attributes' EIP-1559 parameters in the header, but this is not the desired result.

Instead, we should be including the EIP-1559 parameters that were selected for the block. That is, if the parent header's nonce field is B64::ZERO, we should be including the canyon base fee parameters in the Header, not what was sent through the PayloadAttributes.

In addition, the attributes builder must send a zero'd out EIP1559params in the payload if the SystemConfig does not yet have a view of the EIP-1559 params.

@clabby clabby added K-fix Kind: fix A-executor Area: kona-executor crate labels Oct 4, 2024
@clabby clabby self-assigned this Oct 4, 2024
@clabby clabby requested a review from refcell October 4, 2024 18:11
@clabby clabby marked this pull request as draft October 4, 2024 18:12
Copy link
Collaborator

@refcell refcell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch!

Copy link

codecov bot commented Oct 4, 2024

Codecov Report

Attention: Patch coverage is 80.61224% with 19 lines in your changes missing coverage. Please review.

Project coverage is 81.6%. Comparing base (a9dd0e7) to head (bfd466b).
Report is 1 commits behind head on main.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
crates/executor/src/lib.rs 53.6% 19 Missing ⚠️
Additional details and impacted files

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@clabby clabby requested a review from refcell October 4, 2024 18:25
@clabby clabby marked this pull request as ready for review October 4, 2024 18:25
@clabby clabby enabled auto-merge October 4, 2024 18:35
@clabby clabby added this pull request to the merge queue Oct 4, 2024
@clabby clabby removed this pull request from the merge queue due to a manual request Oct 4, 2024
@clabby clabby enabled auto-merge October 4, 2024 19:00
@clabby clabby added this pull request to the merge queue Oct 4, 2024
Merged via the queue into main with commit 44ad84c Oct 4, 2024
16 of 17 checks passed
This was referenced Oct 9, 2024
@github-actions github-actions bot mentioned this pull request Oct 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-executor Area: kona-executor crate K-fix Kind: fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants