-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(executor): Holocene EIP-1559 params in Header #622
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch!
Codecov ReportAttention: Patch coverage is
✅ All tests successful. No failed tests found.
Additional details and impacted files☔ View full report in Codecov by Sentry. |
ac8d351
to
197b616
Compare
197b616
to
24cac36
Compare
Overview
Fixes the inclusion of the current block's base fee parameters within the Header. As-is, it always includes the payload attributes' EIP-1559 parameters in the header, but this is not the desired result.
Instead, we should be including the EIP-1559 parameters that were selected for the block. That is, if the parent header's
nonce
field isB64::ZERO
, we should be including the canyon base fee parameters in theHeader
, not what was sent through thePayloadAttributes
.In addition, the attributes builder must send a zero'd out EIP1559params in the payload if the
SystemConfig
does not yet have a view of the EIP-1559 params.