Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(derive): Test and Clean Batch Types #670

Merged
merged 3 commits into from
Oct 9, 2024
Merged

chore(derive): Test and Clean Batch Types #670

merged 3 commits into from
Oct 9, 2024

Conversation

refcell
Copy link
Collaborator

@refcell refcell commented Oct 9, 2024

Description

Tests and cleans derivation batch types.

@refcell refcell requested a review from clabby as a code owner October 9, 2024 15:17
@refcell refcell self-assigned this Oct 9, 2024
@refcell refcell added K-chore Kind: chore A-derive Area: kona-derive crate M-tests Meta: Testing related labels Oct 9, 2024
@codecov Codecov
Copy link

codecov bot commented Oct 9, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.5%. Comparing base (d3f8045) to head (e7be644).

✅ All tests successful. No failed tests found.

Additional details and impacted files

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

clabby
clabby approved these changes Oct 9, 2024
View reviewed changes
Copy link
Collaborator

@clabby clabby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

very nice mr allen

@clabby clabby added this pull request to the merge queue Oct 9, 2024
Merged via the queue into main with commit c2eb864 Oct 9, 2024
15 checks passed
This was referenced Oct 9, 2024
Closed
Closed
Closed
@github-actions github-actions bot mentioned this pull request Oct 19, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@clabby clabby clabby approved these changes

Assignees

@refcell refcell

Labels
A-derive Area: kona-derive crate K-chore Kind: chore M-tests Meta: Testing related
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@refcell @clabby