Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(derive): Upstream Indexed Blob Hash #710

Closed
wants to merge 1 commit into from

Conversation

refcell
Copy link
Collaborator

@refcell refcell commented Oct 19, 2024

Description

Removes the IndexedBlobHash and re-uses the type introduced in alloy-rs/alloy#1526.

Metadata

Closes #706

@refcell refcell self-assigned this Oct 19, 2024
@refcell refcell added K-chore Kind: chore A-derive Area: kona-derive crate labels Oct 19, 2024
Comment on lines +57 to +67
[patch.crates-io]
alloy-eips = { git = "https://github.com/refcell/alloy", branch = "rf/feat/indexed-blob-hash" }
alloy-serde = { git = "https://github.com/refcell/alloy", branch = "rf/feat/indexed-blob-hash" }
alloy-provider = { git = "https://github.com/refcell/alloy", branch = "rf/feat/indexed-blob-hash" }
alloy-consensus = { git = "https://github.com/refcell/alloy", branch = "rf/feat/indexed-blob-hash" }
alloy-transport = { git = "https://github.com/refcell/alloy", branch = "rf/feat/indexed-blob-hash" }
alloy-rpc-types = { git = "https://github.com/refcell/alloy", branch = "rf/feat/indexed-blob-hash" }
alloy-rpc-client = { git = "https://github.com/refcell/alloy", branch = "rf/feat/indexed-blob-hash" }
alloy-node-bindings = { git = "https://github.com/refcell/alloy", branch = "rf/feat/indexed-blob-hash" }
alloy-transport-http = { git = "https://github.com/refcell/alloy", branch = "rf/feat/indexed-blob-hash" }
alloy-rpc-types-engine = { git = "https://github.com/refcell/alloy", branch = "rf/feat/indexed-blob-hash" }
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TODO: Remove these and bump alloy dep versions once a release is published that includes the IndexedBlobHash type.

Copy link

codecov bot commented Oct 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (main@a53374c). Learn more about missing BASE report.
Report is 63 commits behind head on main.

✅ All tests successful. No failed tests found.

Additional details and impacted files

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@refcell refcell changed the title feat: Upstream Indexed Blob Hash feat(derive): Upstream Indexed Blob Hash Oct 21, 2024
@refcell refcell added M-do-not-merge Meta: Do not merge and removed K-chore Kind: chore A-derive Area: kona-derive crate labels Oct 21, 2024
@refcell
Copy link
Collaborator Author

refcell commented Nov 6, 2024

#786 replaces this

@refcell refcell closed this Nov 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
M-do-not-merge Meta: Do not merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

fix(derive): Upstream IndexedBlobHash to Alloy
1 participant