Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(derive): BatchProvider multiplexed stage #726

Merged
merged 6 commits into from
Oct 22, 2024
Merged

Conversation

clabby
Copy link
Collaborator

@clabby clabby commented Oct 21, 2024

Overview

Implements the BatchProvider stage, which is a mux over BatchQueue (< holocene) and BatchValidator (>= holocene).

TODO

  • Retain l1_blocks when transforming the BatchQueue into the BatchValidator.

@clabby
Copy link
Collaborator Author

clabby commented Oct 21, 2024

📚 $\text{Stack Overview}$

Pulls submitted in this stack:

This comment was automatically generated by st.

@clabby clabby self-assigned this Oct 21, 2024
@clabby clabby added K-feature Kind: feature A-derive Area: kona-derive crate H-holocene Hardfork: Holocene related labels Oct 21, 2024
Copy link

codecov bot commented Oct 21, 2024

❌ 1 Tests Failed:

Tests completed Failed Passed Skipped
317 1 316 0
View the full list of 1 ❄️ flaky tests
kona-mpt list_walker::test::test_online_list_walker_transactions

Flake rate in main: 20.00% (Passed 8 times, Failed 2 times)

Stack Traces | 0.082s run time
thread &apos;list_walker::test::test_online_list_walker_transactions&apos; panicked at .../mpt/src/list_walker.rs:197:89:
called `Result::unwrap()` on an `Err` value: HTTP error 429 with body: {&quot;code&quot;:-32007,&quot;message&quot;:&quot;5/second request limit reached - reduce calls per second or upgrade your account at quicknode.com&quot;}

Caused by:
    HTTP error 429 with body: {&quot;code&quot;:-32007,&quot;message&quot;:&quot;5/second request limit reached - reduce calls per second or upgrade your account at quicknode.com&quot;}
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace

To view individual test run time comparison to the main branch, go to the Test Analytics Dashboard

@clabby clabby force-pushed the cl/multiplex-bq branch 2 times, most recently from 43553d3 to c694a04 Compare October 21, 2024 19:40
@clabby clabby requested a review from refcell October 21, 2024 20:31
@clabby clabby marked this pull request as ready for review October 21, 2024 23:27
Copy link
Collaborator

@refcell refcell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's not so bad without a macro :)

@refcell refcell added this pull request to the merge queue Oct 22, 2024
@refcell refcell removed this pull request from the merge queue due to a manual request Oct 22, 2024
@refcell refcell added this pull request to the merge queue Oct 22, 2024
Merged via the queue into main with commit 4e07ad2 Oct 22, 2024
14 of 15 checks passed
@github-actions github-actions bot mentioned this pull request Oct 22, 2024
TomTaehoonKim pushed a commit to TomTaehoonKim/kona that referenced this pull request Nov 5, 2024
* feat(derive): `BatchProvider` multiplexed stage

* tests

* monolithic mux macro -> viking funeral ⛵🔥

* rebase

* updates

* remove `into_prev`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-derive Area: kona-derive crate H-holocene Hardfork: Holocene related K-feature Kind: feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants