-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(derive): BatchProvider
multiplexed stage
#726
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
📚
|
clabby
added
K-feature
Kind: feature
A-derive
Area: kona-derive crate
H-holocene
Hardfork: Holocene related
labels
Oct 21, 2024
❌ 1 Tests Failed:
View the full list of 1 ❄️ flaky tests
To view individual test run time comparison to the main branch, go to the Test Analytics Dashboard |
refcell
reviewed
Oct 21, 2024
refcell
requested changes
Oct 21, 2024
clabby
force-pushed
the
cl/multiplex-bq
branch
2 times, most recently
from
October 21, 2024 19:40
43553d3
to
c694a04
Compare
clabby
force-pushed
the
cl/multiplex-bq
branch
from
October 21, 2024 23:01
26d1bec
to
8b64e0b
Compare
refcell
approved these changes
Oct 22, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's not so bad without a macro :)
Merged
TomTaehoonKim
pushed a commit
to TomTaehoonKim/kona
that referenced
this pull request
Nov 5, 2024
* feat(derive): `BatchProvider` multiplexed stage * tests * monolithic mux macro -> viking funeral ⛵🔥 * rebase * updates * remove `into_prev`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Implements the
BatchProvider
stage, which is a mux overBatchQueue
(< holocene) andBatchValidator
(>= holocene).TODO
l1_blocks
when transforming theBatchQueue
into theBatchValidator
.