Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(driver): Abstract, Default Pipeline #796

Merged
merged 2 commits into from
Nov 10, 2024
Merged

Conversation

refcell
Copy link
Collaborator

@refcell refcell commented Nov 8, 2024

Description

Abstracts the driver pipeline trait to allow for a default payload production loop.

Avoids driver implementors from footgunning themselves with rolling their own payload loops.

@refcell refcell requested a review from clabby as a code owner November 8, 2024 15:45
@refcell refcell added A-client Area: client binary A-derive Area: kona-derive crate K-feature Kind: feature labels Nov 8, 2024
@refcell refcell self-assigned this Nov 8, 2024
@refcell
Copy link
Collaborator Author

refcell commented Nov 8, 2024

📚 $\text{Stack Overview}$

Pulls submitted in this stack:

This comment was automatically generated by st.

Copy link

codecov bot commented Nov 8, 2024

Codecov Report

Attention: Patch coverage is 0% with 69 lines in your changes missing coverage. Please review.

Project coverage is 91.9%. Comparing base (b79054a) to head (d9e4cc5).
Report is 1 commits behind head on main.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
crates/driver/src/pipeline.rs 0.0% 43 Missing ⚠️
crates/driver/src/core.rs 0.0% 17 Missing ⚠️
crates/derive/src/pipeline/core.rs 0.0% 9 Missing ⚠️
Additional details and impacted files

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@clabby clabby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - to reduce the feeling of nesting, it'd be nice to lift some of the step / inner etc. functions into the pipeline itself.

crates/driver/src/core.rs Outdated Show resolved Hide resolved
@refcell refcell changed the base branch from rf/feat/driver to main November 10, 2024 22:22
@refcell refcell added this pull request to the merge queue Nov 10, 2024
Merged via the queue into main with commit 8acfb82 Nov 10, 2024
15 of 16 checks passed
@github-actions github-actions bot mentioned this pull request Nov 8, 2024
@github-actions github-actions bot mentioned this pull request Nov 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-client Area: client binary A-derive Area: kona-derive crate K-feature Kind: feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants