Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add support for passing args and environment vars to terraform_validate #114

Conversation

paullschock
Copy link

I set out to allow support for passing environment variables and arguments to terraform_validate in order to address: pre-commit/pre-commit#758 (comment)

I noticed passing multiple arguments to the terraform_tflint hook did not work as documented for two reasons:

  1. documentation examples missing required '--' prefix for args
  2. for loop in main would overwrite $args, thus passing only the last specified "args" item

I resolved this issue for terraform_tflint and carried this pattern into terraform_validate

Added/corrected readme documentation for two affected hooks.

@paullschock paullschock changed the title Add support for passing args and environment vars to terraform_validate feat: Add support for passing args and environment vars to terraform_validate Jun 7, 2020
@paullschock
Copy link
Author

Closing in favor of #125 as the implementation appears to be superior.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant