feat: Allow passing of args to terraform_fmt

[robinbowes]

Fixes #146

[mcaulifn]

config:

repos:
- repo: git://github.com/antonbabenko/pre-commit-terraform
  rev: v1.38.0 # I copied in the script after pulling this version
  hooks:
    - id: terraform_fmt
      args:
        - 'args=-diff'
        - 'args=-write=false'

I get this output:

pre-commit run -a
Terraform fmt............................................................Failed
- hook id: terraform_fmt
- files were modified by this hook

data.tf
main.tf
secrets.tf
vars.tf
data.tf
secrets.tf
vars.tf
data.tf
main.tf
secrets.tf
vars.tf

Terraform docs...........................................................Passed

The files are still written to.

I expect this output:

terraform fmt -diff -write=false
data.tf
--- old/data.tf
+++ new/data.tf
@@ -20,7 +20,7 @@
 
 locals {
   jobs_configurations = {
...

[robinbowes]

Can you try with this config:

repos:
- repo: git://github.com/antonbabenko/pre-commit-terraform
  rev: v1.38.0 # I copied in the script after pulling this version
  hooks:
    - id: terraform_fmt
      args:
        - '-diff'
        - '-write=false'

[mcaulifn]

I get this:

Terraform validate with tfsec............................................Failed
- hook id: terraform_tfsec
- exit code: 1

getopt: invalid option -- 'd'
getopt: invalid option -- 'i'
getopt: invalid option -- 'f'
getopt: invalid option -- 'f'
getopt: invalid option -- 'w'
getopt: invalid option -- 'r'
getopt: invalid option -- 'i'
getopt: invalid option -- 't'
getopt: invalid option -- 'e'
getopt: invalid option -- '='
getopt: invalid option -- 'f'
getopt: invalid option -- 'd'
getopt: invalid option -- 'i'
getopt: invalid option -- 'f'
getopt: invalid option -- 'f'
getopt: invalid option -- 'w'
getopt: invalid option -- 'r'
getopt: invalid option -- 'i'
getopt: invalid option -- 't'
getopt: invalid option -- 'e'
getopt: invalid option -- '='
getopt: invalid option -- 'f'
getopt: invalid option -- 'd'
getopt: invalid option -- 'i'
getopt: invalid option -- 'f'
getopt: invalid option -- 'f'
getopt: invalid option -- 'w'
getopt: invalid option -- 'r'
getopt: invalid option -- 'i'
getopt: invalid option -- 't'
getopt: invalid option -- 'e'
getopt: invalid option -- '='
getopt: invalid option -- 'f'
getopt: invalid option -- 'd'
getopt: invalid option -- 'i'
getopt: invalid option -- 'f'
getopt: invalid option -- 'f'
getopt: invalid option -- 'w'
getopt: invalid option -- 'r'
getopt: invalid option -- 'i'
getopt: invalid option -- 't'
getopt: invalid option -- 'e'
getopt: invalid option -- '='
getopt: invalid option -- 'f'
getopt: invalid option -- 'd'
getopt: invalid option -- 'i'
getopt: invalid option -- 'f'
getopt: invalid option -- 'f'
getopt: invalid option -- 'w'
getopt: invalid option -- 'r'
getopt: invalid option -- 'i'
getopt: invalid option -- 't'
getopt: invalid option -- 'e'
getopt: invalid option -- '='
getopt: invalid option -- 'f'
getopt: invalid option -- 'd'
getopt: invalid option -- 'i'
getopt: invalid option -- 'f'
getopt: invalid option -- 'f'
getopt: invalid option -- 'w'
getopt: invalid option -- 'r'
getopt: invalid option -- 'i'
getopt: invalid option -- 't'
getopt: invalid option -- 'e'
getopt: invalid option -- '='
getopt: invalid option -- 'f'
getopt: invalid option -- 'd'
getopt: invalid option -- 'i'
getopt: invalid option -- 'f'
getopt: invalid option -- 'f'
getopt: invalid option -- 'w'
getopt: invalid option -- 'r'
getopt: invalid option -- 'i'
getopt: invalid option -- 't'
getopt: invalid option -- 'e'
getopt: invalid option -- '='
getopt: invalid option -- 'f'

[robinbowes]

Terraform validate with tfsec............................................Failed

• hook id: terraform_tfsec

Are you sure you're testing the right thing?

[robinbowes]

I tested with this config:

repos:
- repo: ../../../../pre-commit-terraform
  rev: 0f7a047ff1106e05dde797beb84dd1f9613431ac
  hooks:
    - id: terraform_fmt
      args:
        - '--args=-diff'
        - '--args=-write=false'

I ran this command:

 $ pre-commit run -a --config test_config.yaml
Terraform fmt............................................................Passed

[mcaulifn]

well oops

I purposefully introduced an formatting issue to main.tf.

If I do args=-option, I get the following:

pre-commit run -a
Terraform fmt............................................................Failed
- hook id: terraform_fmt
- files were modified by this hook

main.tf
main.tf

If I do --args=-option, I get:

pre-commit run -a
Terraform fmt............................................................Passed

[NeckBeardPrince]

Any update?

[github-actions]

This PR has been automatically marked as stale because it has been open 30 days
with no activity. Remove stale label or comment or this PR will be closed in 10 days

[MaxymVlasov]

It works, usage same as for terraform_validate hook

/tmp/147/pre-commit-terraform/terraform_fmt.sh --args=-diff --args=-write=false dir/file1 dir/file2 file3

Eg.

➜ /tmp/147/pre-commit-terraform/terraform_fmt.sh --args=-diff --args=-write=false modules/rapp-services/aws-ops-web/variables.tf
variables.tf
--- old/variables.tf
+++ new/variables.tf
@@ -42,7 +42,7 @@
       value = var.deployment
       }, {
       name  = "BACKEND"
-      value = ! contains(["qa-1", "qa-2", "qa-3"], var.deployment) ? "core-api" : "rider"
+      value = !contains(["qa-1", "qa-2", "qa-3"], var.deployment) ? "core-api" : "rider"
     }]
     ingress = {
       enabled = true

[MaxymVlasov]

@antonbabenko Can be merged. I will prepare usage doc for terrafrom_fmt as separate PR

[MaxymVlasov]

LGTM