Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

terraform_tflint: Fix files array assignation #78

Closed
wants to merge 1 commit into from
Closed

terraform_tflint: Fix files array assignation #78

wants to merge 1 commit into from

Conversation

maxbrunet
Copy link
Contributor

Files were concatenated into a single space-separated string

How args are passed to the tflint function might have to be improved too.

Here's shellcheck output:

$ shellcheck terraform_tflint.sh                                                                                                                                       [12:11:58]

In terraform_tflint.sh line 36:
    let "index+=1"
    ^-----------^ SC2219: Instead of 'let expr', prefer (( expr )) .


In terraform_tflint.sh line 43:
    tflint $args
           ^---^ SC2086: Double quote to prevent globbing and word splitting.

Did you mean:
    tflint "$args"


In terraform_tflint.sh line 534:
[[ $BASH_SOURCE != "$0" ]] || main "$@"
   ^----------^ SC2128: Expanding an array without an index only gives the first element.

For more information:
  https://www.shellcheck.net/wiki/SC2128 -- Expanding an array without an ind...
  https://www.shellcheck.net/wiki/SC2086 -- Double quote to prevent globbing ...
  https://www.shellcheck.net/wiki/SC2219 -- Instead of 'let expr', prefer (( ...

Files were concatenated into a single space-separated string
@maxbrunet
Copy link
Contributor Author

Closing in favor of #77

@maxbrunet maxbrunet closed this Dec 1, 2019
@maxbrunet maxbrunet deleted the hotfix/tflint-files-list branch December 1, 2019 22:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant