fix jakartaee#231

Signed-off-by: Antonio Santos Izaguirre <antoniosanct@gmail.com>
antoniosanct · Nov 13, 2023 · 3642cf5 · 3642cf5
1 parent b023399
commit 3642cf5
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 0 deletions.
diff --git a/api/src/main/java/jakarta/xml/bind/DatatypeConverterImpl.java b/api/src/main/java/jakarta/xml/bind/DatatypeConverterImpl.java
@@ -706,6 +706,9 @@ private static int guessLength(String text) {
      */
     public static byte[] _parseBase64Binary(String text) {
         final int buflen = guessLength(text);
+        if (buflen < 3) {
+            throw new IllegalArgumentException("base64 text invalid.");
+        }
         final byte[] out = new byte[buflen];
         int o = 0;
 
@@ -725,6 +728,7 @@ public static byte[] _parseBase64Binary(String text) {
             }
 
             if (q == 4) {
+
                 // quadruplet is now filled.
                 out[o++] = (byte) ((quadruplet[0] << 2) | (quadruplet[1] >> 4));
                 if (quadruplet[2] != PADDING) {

diff --git a/api/src/test/java/org/eclipse/jaxb/api/DatatypeConverterTest.java b/api/src/test/java/org/eclipse/jaxb/api/DatatypeConverterTest.java
@@ -55,4 +55,13 @@ public void testParseBoolean() {
         Assert.assertEquals(true, DatatypeConverter.parseBoolean("true "));
         Assert.assertEquals(true, DatatypeConverter.parseBoolean(" true "));
     }
+
+    @Test
+    public void testBase64() {
+        Assert.assertThrows(IllegalArgumentException.class, () -> DatatypeConverter.parseBase64Binary("Qxx=="));
+        Assert.assertNotEquals("Hello, world!", new String(DatatypeConverter.parseBase64Binary("SGVsbG8sIJdvcmxkIQ==")));
+
+        Assert.assertEquals("Hello, world!", new String(DatatypeConverter.parseBase64Binary("SGVsbG8sIHdvcmxkIQ==")));
+    }
+
 }