-
Notifications
You must be signed in to change notification settings - Fork 366
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for Logitech G815 and G513 #1802
Conversation
I noticed the g513 has an fn key, not a windows key. I also noticed the logitech integration contains no definition for an fn key? wondering if a cosmetic change would be sufficient |
I'll have a chat to the guy at #1778 tomorrow and see if he can try, I'll go from there |
In any case you'd just have to add this to the
|
Is there any kind of official documentation for this kind of stuff anywhere?
…On Tue, 12 Nov 2019, 21:31 Diogo Trindade, ***@***.***> wrote:
In any case you'd just have to add this to the key_modifications in the
g513.json file
"99": { "visualName": "FN", "tag": 99, "line_break": null, "margin_left":
null, "margin_top": null, "width": null, "height": null, "font_size": null,
"width_bits": null, "height_bits": null, "margin_left_bits": null,
"margin_top_bits": null, "enabled": null }
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#1802?email_source=notifications&email_token=AINHGC6QQPI37V5XHWNMO63QTMOE7A5CNFSM4JMJFLZ2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOED4AFVI#issuecomment-553124565>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AINHGC4SVIACOT3FROSIS73QTMOE7ANCNFSM4JMJFLZQ>
.
|
No unfortunately. I know because I've added a few layouts before |
I've had no response from the person asking for G513 support, but I can confirm that the G815 works very nicely. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've cloned SamPoulton commit and built it using AppVeyor.
The layouts seems to be working properly.
Media Keys are missing though, but GHUB doesn't let third parties map those keys.
Hi, do you know if this would work with my G815 with linear switches? I heard that there's a problem with this keyboard so G Hub can't recognize it. I can help to test this, but I'm not sure how to build this project on my computer, when I run "Build Solution" in Visual Studio 2019, I get these two errors:
|
Just build Aurora itself rather than the entire solution |
Okay, I built it, but, as expected, it doesn't work with my G815 linear. I guess I'll have to return it, because it's faulty, no software can detect it |
@IhToN sorry but I accidentally closed the PR and the review was deleted, any chance you'd be able to do it again? Nothing's changed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would suggest to move Layout Nodes from the .csproj file from where they are, putting them next to the others layout.
Everything else seems to be correct.
Hey, sorry i'm taking so long to get through the pulls. Is this functional? I don't know if the M keys on the g815 are supported by logitech's sdk. |
Project-Aurora/Project-Aurora/Settings/KeyboardLayoutManager.cs
Outdated
Show resolved
Hide resolved
The M keys are not supported you are right. Although the G1-5 ones are missing on the layout for G810. |
The g810 does not have any macro keys. |
I know, I meant by using the G810 Layout as a temporary solution for the G815 |
I decided to fix the issues i pointed out myself, i hope that's okay. Please test this if you don't mind as i dont have the keyboards to test with. |
List any issues that this PR fixes: fixes # , etc...
Addresses #1778
This pull request proposes the following changes:
Known issues/To do: