Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for Logitech G815 and G513 #1802

Merged
merged 9 commits into from
May 17, 2020
Merged

Support for Logitech G815 and G513 #1802

merged 9 commits into from
May 17, 2020

Conversation

lucyydotp
Copy link
Contributor

List any issues that this PR fixes: fixes # , etc...

Addresses #1778
This pull request proposes the following changes:

  • Support for Logitech G815 and G513

Known issues/To do:

  • None

@diogotr7
Copy link
Collaborator

I noticed the g513 has an fn key, not a windows key. I also noticed the logitech integration contains no definition for an fn key? wondering if a cosmetic change would be sufficient

@lucyydotp
Copy link
Contributor Author

I'll have a chat to the guy at #1778 tomorrow and see if he can try, I'll go from there

@diogotr7
Copy link
Collaborator

In any case you'd just have to add this to the key_modifications in the g513.json file

"99": { "visualName": "FN", "tag": 99, "line_break": null, "margin_left": null, "margin_top": null, "width": null, "height": null, "font_size": null, "width_bits": null, "height_bits": null, "margin_left_bits": null, "margin_top_bits": null, "enabled": null }

@lucyydotp
Copy link
Contributor Author

lucyydotp commented Nov 12, 2019 via email

@diogotr7
Copy link
Collaborator

No unfortunately. I know because I've added a few layouts before

@lucyydotp
Copy link
Contributor Author

I've had no response from the person asking for G513 support, but I can confirm that the G815 works very nicely.

IhToN
IhToN approved these changes Mar 13, 2020
IhToN
IhToN previously approved these changes Mar 13, 2020
Copy link

@IhToN IhToN left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've cloned SamPoulton commit and built it using AppVeyor.
The layouts seems to be working properly.

Media Keys are missing though, but GHUB doesn't let third parties map those keys.

@lusiaold
Copy link

Hi, do you know if this would work with my G815 with linear switches? I heard that there's a problem with this keyboard so G Hub can't recognize it. I can help to test this, but I'm not sure how to build this project on my computer, when I run "Build Solution" in Visual Studio 2019, I get these two errors:

Severity	Code	Description	Project	File	Line	Suppression State
Error	CS0006	Metadata file 'C:\Users\pawel\Projects\Aurora\Build\Release\Aurora.exe' could not be found	Aurora-Updater	C:\Users\pawel\Projects\Aurora\Project-Aurora\Aurora-Updater\CSC	1	N/A
Severity	Code	Description	Project	File	Line	Suppression State
Error		The tag 'KeySequence' does not exist in XML namespace 'clr-namespace:Aurora.Controls;assembly=Aurora'. Line 14 Position 10.	Plugin-Example	C:\Users\pawel\Projects\Aurora\Project-Aurora\Plugin-Example\Layers\Control_ExampleLayer.xaml	14	

@lucyydotp
Copy link
Contributor Author

Just build Aurora itself rather than the entire solution

@lucyydotp lucyydotp closed this Mar 17, 2020
@lucyydotp lucyydotp reopened this Mar 17, 2020
@lusiaold
Copy link

Okay, I built it, but, as expected, it doesn't work with my G815 linear. I guess I'll have to return it, because it's faulty, no software can detect it

@lucyydotp
Copy link
Contributor Author

@IhToN sorry but I accidentally closed the PR and the review was deleted, any chance you'd be able to do it again? Nothing's changed

Copy link

@IhToN IhToN left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would suggest to move Layout Nodes from the .csproj file from where they are, putting them next to the others layout.
Everything else seems to be correct.

@diogotr7
Copy link
Collaborator

Hey, sorry i'm taking so long to get through the pulls.

Is this functional? I don't know if the M keys on the g815 are supported by logitech's sdk.

@IhToN
Copy link

IhToN commented Apr 23, 2020

Hey, sorry i'm taking so long to get through the pulls.

Is this functional? I don't know if the M keys on the g815 are supported by logitech's sdk.

The M keys are not supported you are right. Although the G1-5 ones are missing on the layout for G810.

@diogotr7
Copy link
Collaborator

The g810 does not have any macro keys.

@IhToN
Copy link

IhToN commented Apr 24, 2020

The g810 does not have any macro keys.

I know, I meant by using the G810 Layout as a temporary solution for the G815

@diogotr7
Copy link
Collaborator

I decided to fix the issues i pointed out myself, i hope that's okay.

Please test this if you don't mind as i dont have the keyboards to test with.

@diogotr7 diogotr7 merged commit 4f77710 into antonpup:dev May 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants