Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replaced Wrapper method with the new ingame api for league of legends #1903

Merged
merged 31 commits into from
Mar 25, 2020
Merged

Replaced Wrapper method with the new ingame api for league of legends #1903

merged 31 commits into from
Mar 25, 2020

Conversation

diogotr7
Copy link
Collaborator

@diogotr7 diogotr7 commented Feb 7, 2020

Riot recently added an api to get in game data so i'm using that instead of the old lightfx wrapper for league (that doesnt do that much anyway).

Things to fix / improve:

  • Some way of automatically removing the old wrapper patch from the folder as it makes the web requests not stop sometimes because the pipe remains connected.
  • improvements to the default champion colors.
  • maybe improvements to the default profile colors?
  • some documentation in the layer UI?

@diogotr7
Copy link
Collaborator Author

Might be a good idea to wait some time to see if the API changes. It is not documented yet as it is very recent so things could change.

@diogotr7
Copy link
Collaborator Author

@Wibble199 Wibble199 self-requested a review March 25, 2020 18:36
@diogotr7 diogotr7 merged commit 9eb55d5 into antonpup:dev Mar 25, 2020
@diogotr7 diogotr7 deleted the feature/lol-gsi branch March 25, 2020 18:38
@stdedos
Copy link

stdedos commented May 26, 2020

I am not wishing for "professional" upgrade/downgrade handling, but can there be something?

I am getting this (#1609 (comment))
image

and then also that:
image

@diogotr7
Copy link
Collaborator Author

The first popup is normal (though i'm noticing now that it says overwatch, which is obviously a mistake)
After this, i'm not sure what causes it to continue erroring out. This should happen once when you update, and no more. Does this happen more than once on your system?

@stdedos
Copy link

stdedos commented May 26, 2020

The first popup is normal (though i'm noticing now that it says overwatch, which is obviously a mistake)

I didn't take a screenshot, as I was not planning to report this. I recycled the one I used for Overwatch.

At least, this time, both popups were only shown once! 😃

Good thinking me, that I didn't open a new issue 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants