Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added return of actual operation in LogiLEDWrapper #2054

Merged
merged 4 commits into from
May 31, 2020
Merged

Added return of actual operation in LogiLEDWrapper #2054

merged 4 commits into from
May 31, 2020

Conversation

supergrml
Copy link
Contributor

Related to: #1953

List any issues that this PR fixes: fixes # , etc...

This pull request proposes the following changes:

  • The wrapper returns the actual operation status combined with the init status. This gives the application the chance to check if the device and/or Logitech software is still present.

Known issues/To do:

@diogotr7
Copy link
Collaborator

I dont understand what you're trying to solve here? The wrapper is for logitech games, not devices. This is never used for connecting to LGHUB or LGS from Aurora. The purpose of the wrapper is acting as a replacement to LGS to the eyes of, for example, GTA 5. This allows aurora to capture the lighting intended for logitech devices and display it somewhere else.

@supergrml
Copy link
Contributor Author

If you lose connection to the device or GHub/LGS the wrapper doesn't return an appropriate result. The LogitechLed gives back the right status, this change is meant to be consistent.

@diogotr7
Copy link
Collaborator

This issue does not solve #1953 at all but the wrapper changes do make sense...

I'll take the opportunity to fix an issue i found with the wrapper light event while testing the changes.

Thank you for contributing.

diogotr7 added 2 commits May 31, 2020 15:27
this happens when the user opens an application with a wrapper  (for example terraria with the logitech wrapper enabled) since Application doesn't exist in  this scenario. Dirty fix for now, should fix properly
@diogotr7 diogotr7 merged commit 2dcaf76 into antonpup:dev May 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants