Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI cargo test added #6

Merged
merged 5 commits into from
Mar 22, 2024
Merged

CI cargo test added #6

merged 5 commits into from
Mar 22, 2024

Conversation

lordshashank
Copy link

.github/workflows/ci.yml Outdated Show resolved Hide resolved
@lordshashank
Copy link
Author

@antoyo , is this what you meant?

@antoyo
Copy link
Owner

antoyo commented Mar 22, 2024

Yes, thanks!

I thought I approved the CI, but it seems I didn't. Now, the CI should run.

@lordshashank
Copy link
Author

@antoyo any insights on why are the CI failing here?

@antoyo
Copy link
Owner

antoyo commented Mar 22, 2024

It seems it's because rustc_codegen_gcc was built with --release, but the y.sh cargo build uses the debug version.

@lordshashank
Copy link
Author

Added the flag to shift to release version, it may work ig. @antoyo could you run the workflow or let me know if there's some other better way

.github/workflows/ci.yml Outdated Show resolved Hide resolved
@lordshashank
Copy link
Author

@antoyo did that, let me know if something else is needed.

@lordshashank lordshashank requested a review from antoyo March 22, 2024 19:20
@lordshashank
Copy link
Author

lordshashank commented Mar 22, 2024

Yay Successful, LFG 🚀. Thanks for help @antoyo , and sorry for trouble, missed some basic things, would remember them for future, thanks.

@antoyo antoyo merged commit f16a006 into antoyo:master Mar 22, 2024
34 checks passed
@antoyo
Copy link
Owner

antoyo commented Mar 22, 2024

Thanks for your contribution!

@lordshashank lordshashank deleted the issue-400 branch March 22, 2024 19:33
@antoyo
Copy link
Owner

antoyo commented Mar 22, 2024

Yay Successful, LFG 🚀. Thanks for help @antoyo , and sorry for trouble, missed some basic things, would remember them for future, thanks.

No worries :) .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add test of ./y.sh cargo in the CI
2 participants