Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add copy right info automatically. #3100

Closed
luolanzone opened this issue Dec 7, 2021 · 2 comments
Closed

Add copy right info automatically. #3100

luolanzone opened this issue Dec 7, 2021 · 2 comments
Labels
good first issue Good for newcomers kind/design Categorizes issue or PR as related to design.

Comments

@luolanzone
Copy link
Contributor

Describe what you are trying to solve

We would see copy right missing in codes during review every now and then, it would be better if Antrea provides CI to add
copy right info automatically.
Describe the solution you have in mind

Add a new target in Makefile like make check-copyright to check any missing copyright and add it automatically.

Describe how your solution impacts user flows

N/A
Describe the main design/architecture of your solution

We can start from here 👉 https://github.com/google/addlicense

Alternative solutions that you considered

Test plan

Additional context
@luolanzone luolanzone added kind/design Categorizes issue or PR as related to design. good first issue Good for newcomers labels Dec 7, 2021
@bangqipropel
Copy link
Contributor

will it also contain that replace the old copyright? I also see some copyright is also 2020, and will it be updated to 2022?

@luolanzone
Copy link
Contributor Author

@bangqipropel no, we shouldn't replace old copy right, only check those files without copyright and add it.

bangqipropel pushed a commit to bangqipropel/antrea that referenced this issue Dec 14, 2021
addlicense Close antrea-io#3100
88eb405 
Signed-off-by: zbangqi <zbangqi@vmware.com>
bangqipropel pushed a commit to bangqipropel/antrea that referenced this issue Dec 14, 2021
addlicense
f123217 
Closes antrea-io#3100

Signed-off-by: zbangqi <zbangqi@vmware.com>
bangqipropel pushed a commit to bangqipropel/antrea that referenced this issue Dec 16, 2021
addlicense
5693437 
Closes antrea-io#3100

Signed-off-by: zbangqi <zbangqi@vmware.com>
bangqipropel pushed a commit to bangqipropel/antrea that referenced this issue Dec 16, 2021
addlicense
6961f59 
Closes antrea-io#3100

Signed-off-by: zbangqi <zbangqi@vmware.com>
@bangqipropel bangqipropel mentioned this issue Dec 16, 2021
Merged
bangqipropel pushed a commit to bangqipropel/antrea that referenced this issue Dec 16, 2021
addlicense
744dd7d 
1. add make check-copyright in Makefile to check or add copyright for files automatically
2. check if all needed copyright is added in workflow
3. add copyright for files
Closes antrea-io#3100

Signed-off-by: zbangqi <zbangqi@vmware.com>
bangqipropel pushed a commit to bangqipropel/antrea that referenced this issue Dec 16, 2021
addlicense
d6d9b72 
1. add make check-copyright in Makefile to check or add copyright for files automatically
2. check if all needed copyright is added in workflow
3. add copyright for files
Closes antrea-io#3100

Signed-off-by: zbangqi <zbangqi@vmware.com>
bangqipropel pushed a commit to bangqipropel/antrea that referenced this issue Dec 16, 2021
addlicense
2c88847 
1. add make check-copyright in Makefile to check or add copyright for files automatically
2. check if all needed copyright is added in workflow
3. add copyright for files
Closes antrea-io#3100

Signed-off-by: zbangqi <zbangqi@vmware.com>
bangqipropel pushed a commit to bangqipropel/antrea that referenced this issue Dec 16, 2021
addlicense
86be0df 
1. add make check-copyright in Makefile to check or add copyright for files automatically
2. check if all needed copyright is added in workflow
3. add copyright for files
Closes antrea-io#3100

Signed-off-by: zbangqi <zbangqi@vmware.com>
bangqipropel pushed a commit to bangqipropel/antrea that referenced this issue Jan 4, 2022
addlicense
9878a9e 
    1. add make check-copyright in Makefile to check or add copyright for files automatically
    2. check if all needed copyright is added in workflow
    3. add copyright for files
    Closes antrea-io#3100

    Signed-off-by: zbangqi <zbangqi@vmware.com>
bangqipropel pushed a commit to bangqipropel/antrea that referenced this issue Jan 4, 2022
addlicense
34a67c9 
    1. add make check-copyright in Makefile to check or add copyright for files automatically
    2. check if all needed copyright is added in workflow
    3. add copyright for files
    Closes antrea-io#3100

    Signed-off-by: zbangqi <zbangqi@vmware.com>
bangqipropel pushed a commit to bangqipropel/antrea that referenced this issue Jan 4, 2022
addlicense
4bcb0da 
    1. add make check-copyright in Makefile to check or add copyright for files automatically
    2. check if all needed copyright is added in workflow
    3. add copyright for files
    Closes antrea-io#3100

    Signed-off-by: zbangqi <zbangqi@vmware.com>
bangqipropel pushed a commit to bangqipropel/antrea that referenced this issue Jan 4, 2022
addlicense
6d9d741 
    1. add make check-copyright in Makefile to check or add copyright for files automatically
    2. check if all needed copyright is added in workflow
    3. add copyright for files
    Closes antrea-io#3100

    Signed-off-by: zbangqi <zbangqi@vmware.com>
bangqipropel pushed a commit to bangqipropel/antrea that referenced this issue Jan 4, 2022
addlicense
b9cdf2e 
    1. add make check-copyright in Makefile to check or add copyright for files automatically
    2. check if all needed copyright is added in workflow
    3. add copyright for files
    Closes antrea-io#3100

    Signed-off-by: zbangqi <zbangqi@vmware.com>
bangqipropel pushed a commit to bangqipropel/antrea that referenced this issue Jan 5, 2022
addlicense
48e828b 
    1. add make check-copyright in Makefile to check or add copyright for files automatically
    2. check if all needed copyright is added in workflow
    3. add copyright for files
    Closes antrea-io#3100

    Signed-off-by: zbangqi <zbangqi@vmware.com>
bangqipropel pushed a commit to bangqipropel/antrea that referenced this issue Jan 5, 2022
addlicense
2466409 
    1. add make check-copyright and add-copyright in Makefile to check and add copyright for files automatically
    2. check if all needed copyright is added in workflow
    3. add copyright for files
    Closes antrea-io#3100

    Signed-off-by: zbangqi <zbangqi@vmware.com>
bangqipropel pushed a commit to bangqipropel/antrea that referenced this issue Jan 5, 2022
addlicense
ce0d6be 
    1. add make check-copyright and add-copyright in Makefile to check and add copyright for files automatically
    2. check if all needed copyright is added in workflow
    3. add copyright for files
    Closes antrea-io#3100

    Signed-off-by: zbangqi <zbangqi@vmware.com>
bangqipropel pushed a commit to bangqipropel/antrea that referenced this issue Jan 5, 2022
addlicense
f3c061c 
    1. add make check-copyright and add-copyright in Makefile to check and add copyright for files automatically
    2. check if all needed copyright is added in workflow
    3. add copyright for files
    Closes antrea-io#3100

    Signed-off-by: zbangqi <zbangqi@vmware.com>
bangqipropel pushed a commit to bangqipropel/antrea that referenced this issue Jan 6, 2022
addlicense
a6d6387 
    1. add make check-copyright and add-copyright in Makefile to check and add copyright for files automatically
    2. check if all needed copyright is added in workflow
    3. add copyright for files
    Closes antrea-io#3100

    Signed-off-by: zbangqi <zbangqi@vmware.com>
bangqipropel pushed a commit to bangqipropel/antrea that referenced this issue Jan 6, 2022
addlicense
144d8d6 
        1. add make check-copyright and add-copyright in Makefile to check and add copyright for files automatically
        2. check if all needed copyright is added in workflow
        3. add copyright for files
        Closes antrea-io#3100

        Signed-off-by: zbangqi <zbangqi@vmware.com>
bangqipropel pushed a commit to bangqipropel/antrea that referenced this issue Jan 6, 2022
addlicense
d1cfbec 
        1. add make check-copyright and add-copyright in Makefile to check and add copyright for files automatically
        2. check if all needed copyright is added in workflow
        3. add copyright for files
        Closes antrea-io#3100

Signed-off-by: zbangqi <zbangqi@vmware.com>
bangqipropel pushed a commit to bangqipropel/antrea that referenced this issue Jan 6, 2022
addlicense
4d68a96 
        1. add make check-copyright and add-copyright in Makefile to check and add copyright for files automatically
        2. check if all needed copyright is added in workflow
        3. add copyright for files
        Closes antrea-io#3100

Signed-off-by: zbangqi <zbangqi@vmware.com>
bangqipropel pushed a commit to bangqipropel/antrea that referenced this issue Jan 10, 2022
addlicense
6ea168f 
        1. add make check-copyright and add-copyright in Makefile to check and add copyright for files automatically
        2. check if all needed copyright is added in workflow
        3. add copyright for files
        Closes antrea-io#3100

Signed-off-by: zbangqi <zbangqi@vmware.com>
bangqipropel pushed a commit to bangqipropel/antrea that referenced this issue Feb 9, 2022
addlicense
17bd71f 
1. add make check-copyright and add-copyright in Makefile to check and add copyright for files automatically
2. check if all needed copyright is added in workflow
3. add copyright for files
Closes antrea-io#3100

Signed-off-by: zbangqi <zbangqi@vmware.com>
bangqipropel pushed a commit to bangqipropel/antrea that referenced this issue Feb 9, 2022
addlicense
b6fb678 
1. add make check-copyright and add-copyright in Makefile to check and add copyright for files automatically
2. check if all needed copyright is added in workflow
3. add copyright for files
Closes antrea-io#3100

Signed-off-by: zbangqi <zbangqi@vmware.com>
bangqipropel pushed a commit to bangqipropel/antrea that referenced this issue Feb 18, 2022
addlicense
1546a8d 
1. add make check-copyright and add-copyright in Makefile to check and add copyright for files automatically
2. check if all needed copyright is added in workflow
3. add copyright for files
Closes antrea-io#3100

Signed-off-by: zbangqi <zbangqi@vmware.com>
bangqipropel added a commit to bangqipropel/antrea that referenced this issue Mar 2, 2022
@bangqipropel
addlicense (antrea-io#3122)
7ba3a80 
1. add make check-copyright and add-copyright in Makefile to check and add copyright for files automatically
2. check if all needed copyright headers have been added with workflow
3. add missing copyright headers

Closes antrea-io#3100 

Signed-off-by: zbangqi <zbangqi@vmware.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers kind/design Categorizes issue or PR as related to design.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@bangqipropel @luolanzone