Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Proposal] A new PacketSampling CRD #5443

Open
hangyan opened this issue Aug 25, 2023 · 5 comments
Open

[Proposal] A new PacketSampling CRD #5443

hangyan opened this issue Aug 25, 2023 · 5 comments
Labels
kind/design Categorizes issue or PR as related to design.

Comments

@hangyan
Copy link
Member

hangyan commented Aug 25, 2023

Describe what you are trying to solve

Traceflow works well for network flow diagnose, but sometimes users may want to take a look into the raw packet in the flow. Currently, antrea lacks the ability to capture raw packet in live traffic.

Describe the solution you have in mind

Add a new CRD to support the packet sampling future. This future will allow user to capture raw packet data for further diagnose.

apiVersion: crd.antrea.io/v1alpha1
kind: PacketSampling
metadata:
  name: tf-test
spec:
  timeout: 60             # a hard limit for all sampling session
  type: FirstNSampling    # support one type first
  parameters: 
    number: 15            # the number of packets to be captured
  source:                 # same selector as Traceflow
    namespace: default
    pod: tcp-sts-0
  destination:
    namespace: default
    pod: tcp-sts-2   
  packet:
    ipHeader: 
      protocol: 6 
    transportHeader:
      tcp:
        srcPort: 10000 
        dstPort: 80 
  fileServer:
    url: sftp://youtestdomain.com:22/root/test
  authentication:
    authType: “BasicAuthenticaion“
    authSecret:
      name: support-bundle-secret
      namespace: default

Describe how your solution impacts user flows

The default (first supported) capture method will have great peformance impact on user flows, see #5345 (comment)

Describe the main design/architecture of your solution

design doc

Alternative solutions that you considered

extend the current Traceflow CRD
Test plan

Additional context

@hangyan hangyan added the kind/design Categorizes issue or PR as related to design. label Aug 25, 2023
@luolanzone
Copy link
Contributor

@hangyan please help to estimate the implementation efforts for the new design, and help to confirm if this can be included in Antrea 1.14 or not. Thanks.

@hangyan
Copy link
Member Author

hangyan commented Sep 12, 2023

@shi0rik0 Please take a look if you are interested.

Copy link
Contributor

This issue is stale because it has been open 90 days with no activity. Remove stale label or comment, or this will be closed in 90 days

@github-actions github-actions bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Dec 12, 2023
@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Mar 11, 2024
@tnqn tnqn reopened this Mar 11, 2024
@github-actions github-actions bot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Mar 12, 2024
Copy link
Contributor

This issue is stale because it has been open 90 days with no activity. Remove stale label or comment, or this will be closed in 90 days

@github-actions github-actions bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jun 10, 2024
@luolanzone luolanzone removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jul 25, 2024
Copy link
Contributor

This issue is stale because it has been open 90 days with no activity. Remove stale label or comment, or this will be closed in 90 days

@github-actions github-actions bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Oct 24, 2024
@luolanzone luolanzone removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Oct 24, 2024
hangyan added a commit to hangyan/antrea that referenced this issue Nov 1, 2024
Signed-off-by: Hang Yan <yhang@vmware.com>
Co-authored-by: Lan <luola@vmware.com>
Co-authored-by: Quan Tian <quan.tian@broadcom.com>
Co-authored-by: Antonin Bas <antonin.bas@gmail.com>
antoninbas added a commit that referenced this issue Nov 4, 2024
API only, no controller yet

Signed-off-by: Hang Yan <yhang@vmware.com>
Co-authored-by: Lan <luola@vmware.com>
Co-authored-by: Quan Tian <quan.tian@broadcom.com>
Co-authored-by: Antonin Bas <antonin.bas@broadcom.com>
hangyan added a commit to hangyan/antrea that referenced this issue Nov 7, 2024
Introduced a new CRD called PacketCapture, which allow users
to configure capture options on target traffic. If a file server
is specified, the result pcap file will be uploaded. The pcap
file can be inspected by tools like wireshark or tcpdump.

Signed-off-by: Hang Yan <yhang@vmware.com>
hangyan added a commit to hangyan/antrea that referenced this issue Nov 7, 2024
Introduced a new CRD called PacketCapture, which allow users
to configure capture options on target traffic. If a file server
is specified, the result pcap file will be uploaded. The pcap
file can be inspected by tools like wireshark or tcpdump.

Signed-off-by: Hang Yan <yhang@vmware.com>
Co-authored-by: Lan <luola@vmware.com>
Co-authored-by: Antonin Bas <antonin.bas@gmail.com>
Co-authored-by: Quan Tian <quan.tian@broadcom.com>
hangyan added a commit to hangyan/antrea that referenced this issue Nov 8, 2024
Introduced a new CRD called PacketCapture, which allow users
to configure capture options on target traffic. If a file server
is specified, the result pcap file will be uploaded. The pcap
file can be inspected by tools like wireshark or tcpdump.

Signed-off-by: Hang Yan <yhang@vmware.com>
Co-authored-by: Lan <luola@vmware.com>
Co-authored-by: Antonin Bas <antonin.bas@gmail.com>
Co-authored-by: Quan Tian <quan.tian@broadcom.com>
hangyan added a commit to hangyan/antrea that referenced this issue Nov 8, 2024
Introduced a new CRD called PacketCapture, which allow users
to configure capture options on target traffic. If a file server
is specified, the result pcap file will be uploaded. The pcap
file can be inspected by tools like wireshark or tcpdump.

Signed-off-by: Hang Yan <yhang@vmware.com>
Co-authored-by: Quan Tian <quan.tian@broadcom.com>
Co-authored-by: Lan <luola@vmware.com>
Co-authored-by: Antonin Bas <antonin.bas@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/design Categorizes issue or PR as related to design.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants