Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Antrea Agent should fail when enabling Multicast with WireGuard #5916

Closed
antoninbas opened this issue Jan 24, 2024 · 1 comment · Fixed by #5920
Closed

Antrea Agent should fail when enabling Multicast with WireGuard #5916

antoninbas opened this issue Jan 24, 2024 · 1 comment · Fixed by #5920
Assignees
Labels
kind/bug Categorizes issue or PR as related to a bug.

Comments

@antoninbas
Copy link
Contributor

antoninbas commented Jan 24, 2024

Describe the bug
It seems to me that Multicast and WireGuard cannot be used together in Antrea.
The Multicast code assumes that in encap mode, an OVS tunnel port is created:

MatchInPort(f.tunnelPort).

This is not the case when using WireGuard, as tunneling is then handled by Linux and not by OVS (inter-Node traffic is sent through the antrea-wg0 interface).

To Reproduce
Install the latest Antrea (from main branch) and enable both Multicast and Wireguard.

Expected
The Antrea Agent should reject this configuration.

Actual behavior
The Antrea Agent accepts the configuration and starts normally. The following flow (and potentially others) is installed, even though port 1 (reserved for the tunnel port) does not exist:

 cookie=0x2050000000000, duration=2612.449s, table=Classifier, n_packets=0, n_bytes=0, priority=210,ip,in_port=1,nw_dst=224.0.0.0/4 actions=load:0x1->NXM_NX_REG0[0..3],resubmit(,MulticastEgressRule)

Versions:
Use latest Antrea, to ensure you have this change: #5885
Even though #5885 stopped creating the tunnel interface and brought this behavior to the surface, #5885 is not responsible for this "bug". Multicast was never compatible with WireGuard to begin with.

cc @tnqn @wenyingd @ceclinux

@antoninbas antoninbas added the kind/bug Categorizes issue or PR as related to a bug. label Jan 24, 2024
@wenyingd wenyingd self-assigned this Jan 25, 2024
@wenyingd
Copy link
Contributor

I could add precheck for this.

antoninbas pushed a commit that referenced this issue Jan 30, 2024
Mutlicast feature cannot work with WireGuard or IPSec configurations in encap
mode. The Agent will now return error when Multicast and encryption are enabled
simultaneously, during config validation.

Fixes #5916

Signed-off-by: wenyingd <wenyingd@vmware.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Categorizes issue or PR as related to a bug.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants