Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prometheus metrics: Change summary type metrics to histogram type metrics. #905

Closed
srikartati opened this issue Jul 2, 2020 · 2 comments · Fixed by #1202
Closed

Prometheus metrics: Change summary type metrics to histogram type metrics. #905

srikartati opened this issue Jul 2, 2020 · 2 comments · Fixed by #1202
Assignees
@dreamtalen
Labels
good first issue Good for newcomers

Comments

@srikartati
Copy link
Member

There are summary/summary vector type metrics in Antrea. As per Kubernetes metric overhaul, it is recommended to use histograms instead of summaries. And the summary types are tagged for deprecation.
The main advantages of histogram types are aggregation and inexpensive.
@srikartati srikartati self-assigned this Jul 2, 2020
@srikartati
Copy link
Member Author

There are only three Antrea controller metrics that need to be changed to histogram type:
DurationAppliedToGroupSyncing
DurationAddressGroupSyncing
DurationInternalNetworkPolicySyncing

@srikartati
Copy link
Member Author

I posted the intention of this change in Slack and google groups, and there were no concerns.
As this is a direct swap of metrics type for the above-mentioned metrics, I am tagging this as a good first issue.

@srikartati srikartati added the good first issue Good for newcomers label Jul 20, 2020
@srikartati srikartati changed the title Change summary type metrics to histogram type metrics. Prometheus metrics: Change summary type metrics to histogram type metrics. Jul 20, 2020
@antoninbas antoninbas self-assigned this Jul 31, 2020
@srikartati srikartati assigned dreamtalen and unassigned antoninbas Aug 31, 2020
dreamtalen pushed a commit to dreamtalen/antrea that referenced this issue Sep 2, 2020
Change prometheus metrics type from summary to histogram
ef98a47 
Resolves issue: antrea-io#905
The summary types are tagged for deprecation, Kubernetes recommended to use histograms instead of summaries. The main advantages of histogram types are aggregation and inexpensive. In this commit, we changed three Antrea controller metrics from summary to histogram type. They are DurationAppliedToGroupSyncing, DurationAddressGroupSyncing, and DurationInternalNetworkPolicySyncing.
@dreamtalen dreamtalen mentioned this issue Sep 2, 2020
Merged
dreamtalen pushed a commit to dreamtalen/antrea that referenced this issue Sep 10, 2020
Change prometheus metrics type from summary to histogram
237c921 
Resolves issue: antrea-io#905
The summary types are tagged for deprecation,
Kubernetes recommended to use histograms instead of summaries.
The main advantages of histogram types are aggregation and inexpensive.
In this commit, we changed three Antrea controller metrics from summary
to histogram type. They are DurationAppliedToGroupSyncing,
DurationAddressGroupSyncing, and DurationInternalNetworkPolicySyncing.
dreamtalen pushed a commit to dreamtalen/antrea that referenced this issue Sep 11, 2020
Change prometheus metrics type from summary to histogram
fe66434 
Resolves issue: antrea-io#905
The summary types are tagged for deprecation,
Kubernetes recommended to use histograms instead of summaries.
The main advantages of histogram types are aggregation and inexpensive.
In this commit, we changed three Antrea controller metrics from summary
to histogram type. They are DurationAppliedToGroupSyncing,
DurationAddressGroupSyncing, and DurationInternalNetworkPolicySyncing.
dreamtalen pushed a commit to dreamtalen/antrea that referenced this issue Sep 11, 2020
Change prometheus metrics type from summary to histogram
9f64d5c 
The summary types are tagged for deprecation, Kubernetes recommended to
use histograms instead of summaries. The main advantages of histogram
types are aggregation and inexpensive.

In this commit, we changed three Antrea controller metrics from summary
to histogram type. They are DurationAppliedToGroupSyncing,
DurationAddressGroupSyncing, and DurationInternalNetworkPolicySyncing.

Fixes antrea-io#905
srikartati pushed a commit that referenced this issue Sep 14, 2020
@dreamtalen
Change prometheus metrics type from summary to histogram (#1202)
7d06431 
The summary types are tagged for deprecation, Kubernetes recommended to
use histograms instead of summaries. The main advantages of histogram
types are aggregation and inexpensive.

In this commit, we changed three Antrea controller metrics from summary
to histogram type. They are DurationAppliedToGroupSyncing,
DurationAddressGroupSyncing, and DurationInternalNetworkPolicySyncing.

Fixes #905

Co-authored-by: Yongming Ding <dyongming@vmware.com>
GraysonWu pushed a commit to GraysonWu/antrea that referenced this issue Sep 22, 2020
@dreamtalen @GraysonWu
Change prometheus metrics type from summary to histogram (antrea-io#1202
eda2c7b 
)

The summary types are tagged for deprecation, Kubernetes recommended to
use histograms instead of summaries. The main advantages of histogram
types are aggregation and inexpensive.

In this commit, we changed three Antrea controller metrics from summary
to histogram type. They are DurationAppliedToGroupSyncing,
DurationAddressGroupSyncing, and DurationInternalNetworkPolicySyncing.

Fixes antrea-io#905

Co-authored-by: Yongming Ding <dyongming@vmware.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dreamtalen dreamtalen

Labels
good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Change prometheus metrics type from summary to histogram dreamtalen/antrea
3 participants
@antoninbas @dreamtalen @srikartati