Use ChainExists to reduce memory footprint #2458
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
|
/test-all |
1 similar comment
|
/test-all |
ListChains was used to check if a chain exists. The method used "iptables -t TABLE -S" to list all rules and filter chains from the output. If there are massive iptables chains and rules configured, it would cause a lot of space allocated. benchmark comparison (with 15K iptables rules configured for 1000 services, each of which has 3 endpoints): name old time/op new time/op delta EnsureChain-48 78.2ms ± 3% 27.0ms ± 1% -65.43% (p=0.008 n=5+5) name old alloc/op new alloc/op delta EnsureChain-48 6.06MB ± 0% 0.01MB ± 0% -99.84% (p=0.016 n=4+5) name old allocs/op new allocs/op delta EnsureChain-48 4.16k ± 0% 0.04k ± 0% ~ (p=0.079 n=4+5) Signed-off-by: Quan Tian <qtian@vmware.com>
Codecov Report
@@ Coverage Diff @@
## main #2458 +/- ##
==========================================
+ Coverage 59.79% 64.98% +5.18%
==========================================
Files 284 284
Lines 22171 25413 +3242
==========================================
+ Hits 13258 16515 +3257
+ Misses 7490 7353 -137
- Partials 1423 1545 +122
Flags with carried forward coverage won't be shown. Click here to find out more.
|
tnqn
force-pushed
the
improve-ensure-chain
branch
from
85e2eef to
5c59c36
Compare
antoninbas
approved these changes
Jul 23, 2021
Thanks for the quick review. go-iptables added Sure, will backport it. |
|
/test-all |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ListChains was used to check if a chain exists. The method
used "iptables -t TABLE -S" to list all rules and filter chains from
the output. If there are massive iptables chains and rules configured,
it would cause a lot of space allocated.
benchmark comparison (with 15K iptables rules configured for 1000
services, each of which has 3 endpoints):
Signed-off-by: Quan Tian qtian@vmware.com
For #2457