Log maintenance bug fix in the Flow Aggregator #2522
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
antoninbas
previously approved these changes
Aug 2, 2021
antoninbas
reviewed
Aug 2, 2021
| @@ -15,6 +15,7 @@ | |||
| package main | |||
|
|
|||
| import ( | |||
| "antrea.io/antrea/pkg/log" | |||
There was a problem hiding this comment.
sorry I missed this: this import is in the wrong group
There was a problem hiding this comment.
Yup, I also just realized it. Updated the patch.
Periodic deletion of log files is missing in the Flow Aggreegator. This logic periodically deletes extra files by making sure that max number of files to be 4. This will ensure that no disk space is wasted on the Kubernetes node running the Flow Aggregator. This logic was missed initially when the logging in the Flow Aggregator is added in the beginning adopting the same framework as the Antrea Agent and the Antrea Controller. Signed-off-by: Srikar Tati <stati@vmware.com>
srikartati
force-pushed
the
fix_logs_flow_exporter
branch
from
d0eed33 to
0e7d786
Compare
Codecov Report
@@ Coverage Diff @@
## main #2522 +/- ##
=======================================
Coverage 59.89% 59.90%
=======================================
Files 284 284
Lines 22265 22265
=======================================
+ Hits 13335 13337 +2
+ Misses 7511 7508 -3
- Partials 1419 1420 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
|
antoninbas
approved these changes
Aug 2, 2021
|
/skip-all |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Periodic deletion of log files is missing in the Flow Aggreegator.
This logic periodically deletes extra files by making sure that max
number of files to be 4. This will ensure that no disk space is wasted
on the Kubernetes node running the Flow Aggregator.
This logic was missed initially when the logging in the Flow Aggregator is
added in the beginning adopting the same framework as the Antrea Agent and the
Antrea Controller.
Signed-off-by: Srikar Tati stati@vmware.com