Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove api controlplane.antrea.io/v1beta1 #2631

Merged
merged 1 commit into from
Aug 26, 2021

Conversation

luolanzone
Copy link
Contributor

Resolves #2620

Signed-off-by: Lan Luo luola@vmware.com

@luolanzone luolanzone requested review from antoninbas and tnqn August 24, 2021 03:13
@luolanzone
Copy link
Contributor Author

Hi @tnqn Could you help to confirm a review comment from @antoninbas for this change in a closed PR? #2630 (comment), thanks.

@codecov-commenter
Copy link

codecov-commenter commented Aug 24, 2021

Codecov Report

Merging #2631 (6bc51d7) into main (862d51d) will increase coverage by 19.16%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##             main    #2631       +/-   ##
===========================================
+ Coverage   41.44%   60.61%   +19.16%     
===========================================
  Files         160      283      +123     
  Lines       19402    22783     +3381     
===========================================
+ Hits         8042    13810     +5768     
+ Misses      10625     7503     -3122     
- Partials      735     1470      +735     
Flag Coverage Δ
e2e-tests ∅ <ø> (?)
kind-e2e-tests 48.34% <100.00%> (?)
unit-tests 41.07% <ø> (-0.38%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/apis/controlplane/install/install.go 100.00% <100.00%> (ø)
pkg/apiserver/handlers/endpoint/handler.go 58.82% <0.00%> (-11.77%) ⬇️
pkg/apiserver/handlers/webhook/convert_crd.go 2.56% <0.00%> (ø)
pkg/apiserver/handlers/webhook/mutation_labels.go 24.71% <0.00%> (ø)
pkg/monitor/agent.go 33.33% <0.00%> (ø)
pkg/agent/cniserver/ipam/ipam_service.go 63.15% <0.00%> (ø)
pkg/ipfix/ipfix_intermediate.go 88.23% <0.00%> (ø)
pkg/controller/crdmirroring/crdhandler/tier.go 17.50% <0.00%> (ø)
pkg/legacyapis/controlplane/v1beta2/conversion.go 30.00% <0.00%> (ø)
.../legacyapis/clusterinformation/v1beta1/register.go 92.85% <0.00%> (ø)
... and 230 more

antoninbas
antoninbas previously approved these changes Aug 24, 2021
Copy link
Contributor

@antoninbas antoninbas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@antoninbas
Copy link
Contributor

/test-all

tnqn
tnqn previously approved these changes Aug 24, 2021
Copy link
Member

@tnqn tnqn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tnqn
Copy link
Member

tnqn commented Aug 25, 2021

@luolanzone can you rebase so we can merge it?

Resolves antrea-io#2620

Signed-off-by: Lan Luo <luola@vmware.com>
@luolanzone luolanzone dismissed stale reviews from tnqn and antoninbas via 6bc51d7 August 26, 2021 00:58
@luolanzone
Copy link
Contributor Author

Hi @tnqn @antoninbas thanks for the review, I just rebased and fix the conflicts.

@antoninbas
Copy link
Contributor

/test-all

@tnqn tnqn merged commit f40b4ec into antrea-io:main Aug 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Why do we still have "controlplane.antrea.io/v1beta1"?
4 participants