-
Notifications
You must be signed in to change notification settings - Fork 387
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
remove api controlplane.antrea.io/v1beta1 #2631
Conversation
Hi @tnqn Could you help to confirm a review comment from @antoninbas for this change in a closed PR? #2630 (comment), thanks. |
Codecov Report
@@ Coverage Diff @@
## main #2631 +/- ##
===========================================
+ Coverage 41.44% 60.61% +19.16%
===========================================
Files 160 283 +123
Lines 19402 22783 +3381
===========================================
+ Hits 8042 13810 +5768
+ Misses 10625 7503 -3122
- Partials 735 1470 +735
Flags with carried forward coverage won't be shown. Click here to find out more.
|
b790d02
to
b826d96
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
/test-all |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@luolanzone can you rebase so we can merge it? |
Resolves antrea-io#2620 Signed-off-by: Lan Luo <luola@vmware.com>
b826d96
to
6bc51d7
Compare
Hi @tnqn @antoninbas thanks for the review, I just rebased and fix the conflicts. |
/test-all |
Resolves #2620
Signed-off-by: Lan Luo luola@vmware.com