Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automated cherry pick of #2489: remove tunnel limitation for IPSec #2764

Conversation

luolanzone
Copy link
Contributor

Cherry pick of #2489 on release-1.2.

#2489: remove tunnel limitation for IPSec

For details on the cherry pick process, see the cherry pick requests page.

@luolanzone luolanzone added the kind/cherry-pick Categorizes issue or PR as related to the cherry-pick of a bug fix from the main branch to a release label Sep 13, 2021
@codecov-commenter
Copy link

codecov-commenter commented Sep 13, 2021

Codecov Report

Merging #2764 (1a17264) into release-1.2 (6d7478f) will increase coverage by 0.30%.
The diff coverage is n/a.

Impacted file tree graph

@@               Coverage Diff               @@
##           release-1.2    #2764      +/-   ##
===============================================
+ Coverage        60.12%   60.42%   +0.30%     
===============================================
  Files              284      284              
  Lines            22385    22396      +11     
===============================================
+ Hits             13458    13532      +74     
+ Misses            7493     7423      -70     
- Partials          1434     1441       +7     
Flag Coverage Δ
kind-e2e-tests 47.12% <ø> (+<0.01%) ⬆️
unit-tests 42.55% <ø> (+0.35%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/agent/flowexporter/exporter/exporter.go 79.62% <0.00%> (-0.70%) ⬇️
pkg/agent/agent.go 50.57% <0.00%> (+0.22%) ⬆️
...gent/controller/noderoute/node_route_controller.go 60.59% <0.00%> (+1.33%) ⬆️
pkg/controller/networkpolicy/status_controller.go 76.77% <0.00%> (+5.80%) ⬆️
pkg/agent/openflow/network_policy.go 83.89% <0.00%> (+7.82%) ⬆️

@tnqn
Copy link
Member

tnqn commented Sep 15, 2021

@luolanzone the generated manifest is not up-to-date.

this PR is based on antrea-io#2486 and I verified all tunnel modes with
IPSec in K8s Cluster, it all works fine now, so I remove the limitation
on our docs and the check in the code.

Signed-off-by: Lan Luo <luola@vmware.com>
@luolanzone luolanzone force-pushed the automated-cherry-pick-of-#2489-upstream-release-1.2 branch from 184f652 to 1a17264 Compare September 16, 2021 03:26
@luolanzone
Copy link
Contributor Author

Hi @tnqn I updated the manifests, Could you help to check again? thanks!

Copy link
Member

@tnqn tnqn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks

@tnqn
Copy link
Member

tnqn commented Sep 16, 2021

/skip-all

@tnqn tnqn merged commit 317f0ea into antrea-io:release-1.2 Sep 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/cherry-pick Categorizes issue or PR as related to the cherry-pick of a bug fix from the main branch to a release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants