Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix error handling in Reject implementation #3010

Merged
merged 1 commit into from
Nov 15, 2021

Conversation

GraysonWu
Copy link
Contributor

@GraysonWu GraysonWu commented Nov 9, 2021

Fix error handling in Reject implementation, when determining if the
packet belongs to Service traffic.
Because of the situation described in PR #3006, I didn't notice this
bug before. Fix it in this PR.

Signed-off-by: wgrayson wgrayson@vmware.com

@codecov-commenter
Copy link

codecov-commenter commented Nov 9, 2021

Codecov Report

Merging #3010 (ae84db4) into main (617ce25) will decrease coverage by 1.31%.
The diff coverage is 50.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3010      +/-   ##
==========================================
- Coverage   60.94%   59.63%   -1.32%     
==========================================
  Files         292      292              
  Lines       24708    24710       +2     
==========================================
- Hits        15059    14735     -324     
- Misses       8006     8384     +378     
+ Partials     1643     1591      -52     
Flag Coverage Δ
kind-e2e-tests 46.31% <50.00%> (-1.85%) ⬇️
unit-tests 40.16% <0.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/agent/controller/networkpolicy/reject.go 69.91% <50.00%> (-0.33%) ⬇️
...g/agent/apiserver/handlers/featuregates/handler.go 0.00% <0.00%> (-82.36%) ⬇️
...kg/apiserver/registry/system/supportbundle/rest.go 19.54% <0.00%> (-55.18%) ⬇️
pkg/support/dump_others.go 0.00% <0.00%> (-51.73%) ⬇️
...ver/registry/controlplane/nodestatssummary/rest.go 50.00% <0.00%> (-50.00%) ⬇️
pkg/support/dump.go 8.13% <0.00%> (-49.60%) ⬇️
...g/agent/apiserver/handlers/addressgroup/handler.go 0.00% <0.00%> (-40.00%) ⬇️
...agent/apiserver/handlers/appliedtogroup/handler.go 0.00% <0.00%> (-40.00%) ⬇️
pkg/ovs/ovsctl/ofctl.go 19.10% <0.00%> (-17.98%) ⬇️
pkg/agent/nodeportlocal/k8s/annotations.go 83.87% <0.00%> (-16.13%) ⬇️
... and 18 more

Copy link
Contributor

@antoninbas antoninbas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A better commit message may be:

Fix error handling in Reject implementation

When determining if the packet belongs to Service traffic

pkg/agent/controller/networkpolicy/reject.go Outdated Show resolved Hide resolved
Fix error handling in Reject implementation, when determining if the
packet belongs to Service traffic.

Signed-off-by: wgrayson <wgrayson@vmware.com>
@GraysonWu GraysonWu changed the title Fix reject typo Fix error handling in Reject implementation Nov 9, 2021
Copy link
Member

@tnqn tnqn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tnqn
Copy link
Member

tnqn commented Nov 12, 2021

/test-all

@tnqn tnqn merged commit 416e1ec into antrea-io:main Nov 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants