-
Notifications
You must be signed in to change notification settings - Fork 367
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix error handling in Reject implementation #3010
Conversation
Codecov Report
@@ Coverage Diff @@
## main #3010 +/- ##
==========================================
- Coverage 60.94% 59.63% -1.32%
==========================================
Files 292 292
Lines 24708 24710 +2
==========================================
- Hits 15059 14735 -324
- Misses 8006 8384 +378
+ Partials 1643 1591 -52
Flags with carried forward coverage won't be shown. Click here to find out more.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A better commit message may be:
Fix error handling in Reject implementation
When determining if the packet belongs to Service traffic
Fix error handling in Reject implementation, when determining if the packet belongs to Service traffic. Signed-off-by: wgrayson <wgrayson@vmware.com>
1eb6721
to
ae84db4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
/test-all |
Fix error handling in Reject implementation, when determining if the
packet belongs to Service traffic.
Because of the situation described in PR #3006, I didn't notice this
bug before. Fix it in this PR.
Signed-off-by: wgrayson wgrayson@vmware.com