Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validate namespaces.match of AntreaClusterNetworkPolicy rules #3109

Merged
merged 1 commit into from
Dec 13, 2021

Conversation

tnqn
Copy link
Member

@tnqn tnqn commented Dec 9, 2021

Signed-off-by: Quan Tian qtian@vmware.com

The issue mentioned in #3091 has been encountered by several people, validating the value can avoid misuse of the field.

Signed-off-by: Quan Tian <qtian@vmware.com>
@codecov-commenter
Copy link

codecov-commenter commented Dec 9, 2021

Codecov Report

Merging #3109 (5d57674) into main (b87b76c) will decrease coverage by 13.23%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##             main    #3109       +/-   ##
===========================================
- Coverage   60.83%   47.59%   -13.24%     
===========================================
  Files         295      457      +162     
  Lines       24892    41707    +16815     
===========================================
+ Hits        15142    19849     +4707     
- Misses       8095    19792    +11697     
- Partials     1655     2066      +411     
Flag Coverage Δ
integration-tests 31.37% <ø> (?)
kind-e2e-tests 44.85% <ø> (-2.90%) ⬇️
unit-tests 40.35% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...g/agent/apiserver/handlers/featuregates/handler.go 0.00% <0.00%> (-82.36%) ⬇️
...kg/apiserver/registry/system/supportbundle/rest.go 19.54% <0.00%> (-55.18%) ⬇️
pkg/support/dump_others.go 0.00% <0.00%> (-51.73%) ⬇️
...ver/registry/controlplane/nodestatssummary/rest.go 50.00% <0.00%> (-50.00%) ⬇️
pkg/support/dump.go 8.33% <0.00%> (-48.34%) ⬇️
...egator/apiserver/handlers/recordmetrics/handler.go 0.00% <0.00%> (-44.45%) ⬇️
...g/agent/apiserver/handlers/addressgroup/handler.go 0.00% <0.00%> (-40.00%) ⬇️
...agent/apiserver/handlers/appliedtogroup/handler.go 0.00% <0.00%> (-40.00%) ⬇️
...gregator/apiserver/handlers/flowrecords/handler.go 0.00% <0.00%> (-40.00%) ⬇️
pkg/apiserver/handlers/loglevel/handler.go 0.00% <0.00%> (-38.47%) ⬇️
... and 200 more

Copy link
Contributor

@Dyanngg Dyanngg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix

@antoninbas
Copy link
Contributor

/test-all

@tnqn tnqn merged commit db46115 into antrea-io:main Dec 13, 2021
@tnqn tnqn deleted the validate-self-value branch December 13, 2021 12:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants