-
Notifications
You must be signed in to change notification settings - Fork 388
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use UT instead of E2E test on validating webhook #3112
Conversation
Codecov Report
@@ Coverage Diff @@
## main #3112 +/- ##
==========================================
- Coverage 60.85% 51.47% -9.38%
==========================================
Files 295 464 +169
Lines 24897 53974 +29077
==========================================
+ Hits 15150 27783 +12633
- Misses 8096 23865 +15769
- Partials 1651 2326 +675
Flags with carried forward coverage won't be shown. Click here to find out more.
|
60bc1b2
to
aa897d6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this ends up being more verbose than I expected, but LGTM
aa897d6
to
7738171
Compare
Signed-off-by: wgrayson <wgrayson@vmware.com>
7738171
to
4a9638a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
/test-all |
/test-integration |
2 similar comments
/test-integration |
/test-integration |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
/skip-all As the PR only removes e2e tests, verifying in kind clusters should be enough. |
/skip-integration |
Unfortunatelly there is no skip for integration, need to wait for CI recovery as well. |
/test-integration |
1 similar comment
/test-integration |
Signed-off-by: wgrayson <wgrayson@vmware.com>
Bought up in PR #3104
Signed-off-by: wgrayson wgrayson@vmware.com