Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use UT instead of E2E test on validating webhook #3112

Merged
merged 1 commit into from
Jan 28, 2022

Conversation

GraysonWu
Copy link
Contributor

Bought up in PR #3104
Signed-off-by: wgrayson wgrayson@vmware.com

@codecov-commenter
Copy link

codecov-commenter commented Dec 9, 2021

Codecov Report

Merging #3112 (4a9638a) into main (2fcec4a) will decrease coverage by 9.37%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3112      +/-   ##
==========================================
- Coverage   60.85%   51.47%   -9.38%     
==========================================
  Files         295      464     +169     
  Lines       24897    53974   +29077     
==========================================
+ Hits        15150    27783   +12633     
- Misses       8096    23865   +15769     
- Partials     1651     2326     +675     
Flag Coverage Δ
e2e-tests 51.78% <ø> (?)
integration-tests 31.35% <ø> (?)
kind-e2e-tests 47.87% <ø> (+0.19%) ⬆️
unit-tests 40.93% <ø> (+0.56%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/agent/cniserver/ipam/antrea_ipam_controller.go 12.97% <0.00%> (-48.57%) ⬇️
pkg/ipam/poolallocator/allocator.go 21.28% <0.00%> (-41.14%) ⬇️
pkg/agent/cniserver/pod_configuration_linux.go 26.31% <0.00%> (-40.36%) ⬇️
pkg/agent/cniserver/ipam/antrea_ipam.go 42.16% <0.00%> (-34.31%) ⬇️
pkg/ipam/ipallocator/allocator.go 54.22% <0.00%> (-29.99%) ⬇️
pkg/controller/networkpolicy/endpoint_querier.go 61.46% <0.00%> (-29.97%) ⬇️
pkg/controller/egress/controller.go 61.11% <0.00%> (-27.34%) ⬇️
.../registry/networkpolicy/clustergroupmember/rest.go 64.28% <0.00%> (-23.95%) ⬇️
pkg/agent/util/ethtool/ethtool_linux.go 46.66% <0.00%> (-23.34%) ⬇️
pkg/controller/ipam/validate.go 57.14% <0.00%> (-22.86%) ⬇️
... and 448 more

Copy link
Contributor

@antoninbas antoninbas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this ends up being more verbose than I expected, but LGTM

pkg/controller/networkpolicy/validate_test.go Outdated Show resolved Hide resolved
pkg/controller/networkpolicy/validate_test.go Outdated Show resolved Hide resolved
Signed-off-by: wgrayson <wgrayson@vmware.com>
Copy link
Contributor

@antoninbas antoninbas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@Dyanngg Dyanngg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@GraysonWu
Copy link
Contributor Author

/test-all

@Dyanngg
Copy link
Contributor

Dyanngg commented Dec 13, 2021

/test-integration

2 similar comments
@GraysonWu
Copy link
Contributor Author

/test-integration

@GraysonWu
Copy link
Contributor Author

/test-integration

Copy link
Member

@tnqn tnqn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tnqn
Copy link
Member

tnqn commented Dec 16, 2021

/skip-all

As the PR only removes e2e tests, verifying in kind clusters should be enough.

@tnqn
Copy link
Member

tnqn commented Dec 16, 2021

/skip-integration

@tnqn
Copy link
Member

tnqn commented Dec 16, 2021

Unfortunatelly there is no skip for integration, need to wait for CI recovery as well.

@GraysonWu
Copy link
Contributor Author

/test-integration

1 similar comment
@GraysonWu
Copy link
Contributor Author

/test-integration

@tnqn tnqn merged commit 3406127 into antrea-io:main Jan 28, 2022
yanjunz97 pushed a commit to yanjunz97/antrea that referenced this pull request Feb 14, 2022
Signed-off-by: wgrayson <wgrayson@vmware.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants