Do not override global RUN_E2E_SKIP in e2e script #3173
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Otherwise running the script with `--e2e-all` would not run any NetworkPolicy tests. Signed-off-by: Quan Tian <qtian@vmware.com>
antoninbas
added
the
area/test/infra
Codecov Report
@@ Coverage Diff @@
## main #3173 +/- ##
==========================================
+ Coverage 59.28% 60.44% +1.16%
==========================================
Files 297 297
Lines 25279 25279
==========================================
+ Hits 14987 15281 +294
+ Misses 8645 8327 -318
- Partials 1647 1671 +24
Flags with carried forward coverage won't be shown. Click here to find out more.
|
|
/skip-all validated the script manually |
bangqipropel
pushed a commit
to bangqipropel/antrea
that referenced
this pull request
Jan 19, 2022
Otherwise running the script with `--e2e-all` would not run any NetworkPolicy tests. Signed-off-by: Quan Tian <qtian@vmware.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Otherwise running the script with
--e2e-allwould not run anyNetworkPolicy tests.
Signed-off-by: Quan Tian qtian@vmware.com
Fixes #3172