Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update label of antrea-mc-controller #3266

Merged
merged 1 commit into from
Feb 10, 2022

Conversation

luolanzone
Copy link
Contributor

Update the label of antrea-mc-controller in manifests to make them
consistent as antrea controller and agent.

Signed-off-by: Lan Luo luola@vmware.com

@codecov-commenter
Copy link

codecov-commenter commented Jan 28, 2022

Codecov Report

Merging #3266 (812d9b3) into main (65727f2) will decrease coverage by 10.67%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##             main    #3266       +/-   ##
===========================================
- Coverage   60.07%   49.39%   -10.68%     
===========================================
  Files         331      462      +131     
  Lines       28437    43993    +15556     
===========================================
+ Hits        17083    21731     +4648     
- Misses       9490    19986    +10496     
- Partials     1864     2276      +412     
Flag Coverage Δ
integration-tests 34.04% <ø> (?)
kind-e2e-tests 44.88% <ø> (-3.02%) ⬇️
unit-tests 41.84% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...g/agent/apiserver/handlers/featuregates/handler.go 0.00% <0.00%> (-82.36%) ⬇️
...kg/apiserver/registry/system/supportbundle/rest.go 20.45% <0.00%> (-54.55%) ⬇️
pkg/support/dump.go 8.19% <0.00%> (-49.19%) ⬇️
...egator/apiserver/handlers/recordmetrics/handler.go 0.00% <0.00%> (-44.45%) ⬇️
pkg/support/dump_others.go 0.00% <0.00%> (-44.00%) ⬇️
...g/agent/apiserver/handlers/addressgroup/handler.go 0.00% <0.00%> (-40.00%) ⬇️
...agent/apiserver/handlers/appliedtogroup/handler.go 0.00% <0.00%> (-40.00%) ⬇️
...gregator/apiserver/handlers/flowrecords/handler.go 0.00% <0.00%> (-40.00%) ⬇️
pkg/apiserver/handlers/loglevel/handler.go 0.00% <0.00%> (-38.47%) ⬇️
pkg/agent/util/net.go 17.68% <0.00%> (-22.45%) ⬇️
... and 164 more

jianjuns
jianjuns previously approved these changes Jan 28, 2022
@luolanzone luolanzone requested a review from tnqn February 9, 2022 00:34
@luolanzone
Copy link
Contributor Author

Hi @tnqn Could you help to take a look as well? thanks!

@luolanzone luolanzone added the area/multi-cluster Issues or PRs related to multi cluster. label Feb 9, 2022
@tnqn
Copy link
Member

tnqn commented Feb 9, 2022

/test-multicluster-e2e
/skip-networkpolicy
/skip-e2e
/skip-conformance

tnqn added a commit to tnqn/antrea that referenced this pull request Feb 9, 2022
To avoid issues such as antrea-io#3266, pin markdownlint version.

markdownlint version should be upgraded manually when necessary.

Signed-off-by: Quan Tian <qtian@vmware.com>
Copy link
Member

@tnqn tnqn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Guess you need to update selector of Service, otherwise the endpoints is emtpy, leading to e2e failures.

Update the label of antrea-mc-controller in manifests to make them
consistent as antrea controller and agent.

Signed-off-by: Lan Luo <luola@vmware.com>
@luolanzone
Copy link
Contributor Author

done @tnqn thanks!

@tnqn
Copy link
Member

tnqn commented Feb 9, 2022

/test-multicluster-e2e
/skip-networkpolicy
/skip-e2e
/skip-conformance

@tnqn tnqn merged commit 7eec130 into antrea-io:main Feb 10, 2022
GraysonWu pushed a commit to GraysonWu/antrea that referenced this pull request Feb 10, 2022
Update the label of antrea-mc-controller in manifests to make them
consistent as antrea controller and agent.

Signed-off-by: Lan Luo <luola@vmware.com>
yanjunz97 pushed a commit to yanjunz97/antrea that referenced this pull request Feb 14, 2022
Update the label of antrea-mc-controller in manifests to make them
consistent as antrea controller and agent.

Signed-off-by: Lan Luo <luola@vmware.com>
@luolanzone luolanzone deleted the update-mc-manifests branch March 1, 2022 02:32
bangqipropel pushed a commit to bangqipropel/antrea that referenced this pull request Mar 2, 2022
Update the label of antrea-mc-controller in manifests to make them
consistent as antrea controller and agent.

Signed-off-by: Lan Luo <luola@vmware.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/multi-cluster Issues or PRs related to multi cluster.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants