-
Notifications
You must be signed in to change notification settings - Fork 387
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade to go-ipfix v0.5.12 #3352
Conversation
Codecov Report
@@ Coverage Diff @@
## main #3352 +/- ##
===========================================
+ Coverage 42.11% 54.81% +12.69%
===========================================
Files 200 374 +174
Lines 24150 51262 +27112
===========================================
+ Hits 10171 28098 +17927
- Misses 12922 20725 +7803
- Partials 1057 2439 +1382
Flags with carried forward coverage won't be shown. Click here to find out more.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks Yanjun for the fix.
@@ -1,4 +1,4 @@ | |||
// Copyright 2021 Antrea Authors | |||
// Copyright 2022 Antrea Authors |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why does it need to be 2022?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We don't need to update the old copyright after this file was created.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this one is updated by make codegen
automatically.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
/test-all |
Signed-off-by: Yanjun Zhou <zhouya@vmware.com>
e83f15b
to
ac57a4e
Compare
Got failures in |
/test-all |
/test-integration |
/test-all-features-conformance |
All tests passed. |
Signed-off-by: Yanjun Zhou <zhouya@vmware.com>
Signed-off-by: Yanjun Zhou <zhouya@vmware.com>
This commit adds changes in go-ipfix v0.5.12.
It fixes some issues leading to the unexpected burst in the throughput calculated in the flow aggregator.
Signed-off-by: Yanjun Zhou zhouya@vmware.com