[Multicast] Support IGMPv3 leave action #3389

wenyingd · 2022-03-03T07:44:47Z

IGMPv3 doesn't have an explicit message to describe a member leaving a
multicast group. Instead, IGMPv3 report message is used, but the group
record has an empty "include" sources. So Antrea Agent checks the group
record type and source number with IGMPv3 report message, and picks out
the groups which the member expects to leave.

Fixes #3388

Signed-off-by: wenyingd wenyingd@vmware.com

codecov-commenter · 2022-03-03T07:51:46Z

Codecov Report

Merging #3389 (48c9d7c) into main (24f85ce) will decrease coverage by 8.30%.
The diff coverage is 83.33%.

@@            Coverage Diff             @@
##             main    #3389      +/-   ##
==========================================
- Coverage   62.11%   53.80%   -8.31%     
==========================================
  Files         269      375     +106     
  Lines       26852    51498   +24646     
==========================================
+ Hits        16680    27711   +11031     
- Misses       8334    21376   +13042     
- Partials     1838     2411     +573

Flag	Coverage Δ
e2e-tests	`50.70% <0.00%> (?)`
integration-tests	`35.78% <ø> (?)`
kind-e2e-tests	`47.43% <0.00%> (-1.51%)`	⬇️
unit-tests	`42.64% <100.00%> (+0.29%)`	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
pkg/agent/multicast/mcast_discovery.go	`52.97% <83.33%> (+27.97%)`	⬆️
pkg/agent/cniserver/pod_configuration_linux.go	`26.31% <0.00%> (-40.36%)`	⬇️
pkg/controller/ipam/antrea_ipam_controller.go	`48.71% <0.00%> (-31.57%)`	⬇️
pkg/agent/flowexporter/connections/conntrack.go	`45.71% <0.00%> (-30.48%)`	⬇️
pkg/controller/networkpolicy/endpoint_querier.go	`61.46% <0.00%> (-29.97%)`	⬇️
.../agent/flowexporter/priorityqueue/priorityqueue.go	`63.29% <0.00%> (-29.31%)`	⬇️
pkg/controller/egress/controller.go	`62.19% <0.00%> (-26.26%)`	⬇️
.../flowexporter/connections/conntrack_connections.go	`58.16% <0.00%> (-25.05%)`	⬇️
pkg/controller/ipam/validate.go	`57.95% <0.00%> (-24.31%)`	⬇️
.../registry/networkpolicy/clustergroupmember/rest.go	`64.28% <0.00%> (-23.95%)`	⬇️
... and 338 more

pkg/agent/multicast/mcast_discovery.go

ceclinux · 2022-03-04T01:31:41Z

pkg/agent/multicast/mcast_discovery.go

-			klog.InfoS("Received IGMPv3 Report message", "group", mgroup.String(), "interface", iface.PodName)
+			klog.InfoS("Received IGMPv3 Report message", "group", mgroup.String(), "interface", iface.InterfaceName, "recordType", gr.Type, "sourceCount", gr.NumberOfSources)
+			evtType := groupJoin
+			if gr.Type == protocol.IGMPIsIn && gr.NumberOfSources == 0 {


I think it should be gr.Type == protocol.IGMPToIn

Do you mean we don't check gr.NumberOfSources? I think it is necessary, from rfc 3376 (IGMPv3), recordType==IsIn and source list is empty are required at the same time. https://datatracker.ietf.org/doc/html/rfc3376

Previous versions of IGMP did not support source filters and had a simpler service interface consisting of Join and Leave operations to enable and disable reception of a given multicast address (from *all* sources) on a given interface. The equivalent operations in the new service interface follow: The Join operation is equivalent to IPMulticastListen ( socket, interface, multicast-address, EXCLUDE, {} ) and the Leave operation is equivalent to: IPMulticastListen ( socket, interface, multicast-address, INCLUDE, {} ) where {} is an empty source list.

My bad. I forgot to add gr.NumberOfSources == 0. So the correct logic should be?

if gr.Type == protocol.IGMPToIn && gr.NumberOfSources == 0 {

Should it check if it's MODE_IS_INCLUDE or CHANGE_TO_INCLUDE_MODE? or we handle response only?
https://datatracker.ietf.org/doc/html/rfc3376#section-4.2.12

I think your concern is correct, I would add support for CHANGE_TO_INCLUDE_MODE.

pkg/agent/multicast/mcast_discovery.go

tnqn · 2022-03-08T12:13:42Z

pkg/agent/multicast/mcast_discovery.go

-			klog.InfoS("Received IGMPv3 Report message", "group", mgroup.String(), "interface", iface.PodName)
+			klog.InfoS("Received IGMPv3 Report message", "group", mgroup.String(), "interface", iface.InterfaceName, "recordType", gr.Type, "sourceCount", gr.NumberOfSources)
+			evtType := groupJoin
+			if gr.Type == protocol.IGMPIsIn && gr.NumberOfSources == 0 {


Should it check if it's MODE_IS_INCLUDE or CHANGE_TO_INCLUDE_MODE? or we handle response only?
https://datatracker.ietf.org/doc/html/rfc3376#section-4.2.12

pkg/agent/multicast/mcast_controller_test.go

tnqn · 2022-03-08T13:30:37Z

In commit message:
s/a explicit/an explicit/
s/describe a member leaves a multicast group/describe a member leaving a multicast group/
s/a empty/en empty/
s/the groups from which the member expects to leave/the groups which the member expects to leave/

IGMPv3 doesn't have an explicit message to describe a member leaving a multicast group. Instead, IGMPv3 report message is used, but the group record has an empty "include" sources. So Antrea Agent checks the group record type and source number with IGMPv3 report message, and picks out the groups which the member expects to leave. Signed-off-by: wenyingd <wenyingd@vmware.com>

wenyingd · 2022-03-09T11:27:56Z

/test-all
/skip-windows-all
/skip-ipv6-all
/skip-ipv6-only-all

Windows and IPv6 are not relevant, skip those tests.

tnqn · 2022-03-09T13:04:06Z

@wenyingd there is no update pushed

wenyingd · 2022-03-10T00:35:14Z

@wenyingd there is no update pushed

My bad, seems network issue, changes are pushed

wenyingd · 2022-03-10T00:59:00Z

/test-all
/skip-windows-all
/skip-ipv6-all
/skip-ipv6-only-all

Windows and IPv6 are not relevant, skip those tests.

wenyingd · 2022-03-10T04:41:56Z

/test-multicast-e2e

tnqn

LGTM

tnqn · 2022-03-10T14:42:18Z

@liu4480 @ceclinux any more comment?

wenyingd · 2022-03-11T12:26:15Z

/test-multicast-e2e

ceclinux · 2022-03-15T01:41:52Z

LGTM

ceclinux · 2022-03-16T01:46:17Z

/test-multicast-e2e

wenyingd · 2022-03-16T06:43:10Z

/test-multicast-e2e

XinShuYang · 2022-03-16T09:14:13Z

/test-multicast-e2e

wenyingd · 2022-03-16T11:14:32Z

The failed cases in multicast e2e is about TestAntreaPolicy, not the patch relevant. Multicast dedicated cases are passed

wenyingd force-pushed the multicast_igmpv3_leave branch from d87b248 to c125719 Compare March 3, 2022 07:45

wenyingd requested review from ceclinux, tnqn and liu4480 March 3, 2022 07:45

wenyingd force-pushed the multicast_igmpv3_leave branch from c125719 to 699d80e Compare March 3, 2022 08:08

liu4480 reviewed Mar 3, 2022

View reviewed changes

pkg/agent/multicast/mcast_discovery.go Outdated Show resolved Hide resolved

ceclinux reviewed Mar 4, 2022

View reviewed changes

tnqn reviewed Mar 8, 2022

View reviewed changes

tnqn added this to the Antrea v1.6 release milestone Mar 9, 2022

tnqn added the action/release-note Indicates a PR that should be included in release notes. label Mar 9, 2022

wenyingd force-pushed the multicast_igmpv3_leave branch from 699d80e to 48c9d7c Compare March 10, 2022 00:32

tnqn approved these changes Mar 10, 2022

View reviewed changes

jianjuns approved these changes Mar 10, 2022

View reviewed changes

tnqn requested review from ceclinux and liu4480 March 11, 2022 02:47

tnqn merged commit f64356e into antrea-io:main Mar 18, 2022

wenyingd deleted the multicast_igmpv3_leave branch June 13, 2022 08:47

hongliangl mentioned this pull request Dec 13, 2022

Antrea1.4: Windows node service route logic looks to be broken #4467

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Multicast] Support IGMPv3 leave action #3389

[Multicast] Support IGMPv3 leave action #3389

wenyingd commented Mar 3, 2022 •

edited

Loading

codecov-commenter commented Mar 3, 2022 •

edited

Loading

ceclinux Mar 4, 2022

wenyingd Mar 4, 2022 •

edited

Loading

ceclinux Mar 4, 2022 •

edited

Loading

tnqn Mar 8, 2022

wenyingd Mar 9, 2022

tnqn Mar 8, 2022

tnqn commented Mar 8, 2022

wenyingd commented Mar 9, 2022

tnqn commented Mar 9, 2022

wenyingd commented Mar 10, 2022

wenyingd commented Mar 10, 2022

wenyingd commented Mar 10, 2022

tnqn left a comment

tnqn commented Mar 10, 2022

wenyingd commented Mar 11, 2022

ceclinux commented Mar 15, 2022

ceclinux commented Mar 16, 2022

wenyingd commented Mar 16, 2022

XinShuYang commented Mar 16, 2022

wenyingd commented Mar 16, 2022

[Multicast] Support IGMPv3 leave action #3389

[Multicast] Support IGMPv3 leave action #3389

Conversation

wenyingd commented Mar 3, 2022 • edited Loading

codecov-commenter commented Mar 3, 2022 • edited Loading

Codecov Report

ceclinux Mar 4, 2022

Choose a reason for hiding this comment

wenyingd Mar 4, 2022 • edited Loading

Choose a reason for hiding this comment

ceclinux Mar 4, 2022 • edited Loading

Choose a reason for hiding this comment

tnqn Mar 8, 2022

Choose a reason for hiding this comment

wenyingd Mar 9, 2022

Choose a reason for hiding this comment

tnqn Mar 8, 2022

Choose a reason for hiding this comment

tnqn commented Mar 8, 2022

wenyingd commented Mar 9, 2022

tnqn commented Mar 9, 2022

wenyingd commented Mar 10, 2022

wenyingd commented Mar 10, 2022

wenyingd commented Mar 10, 2022

tnqn left a comment

Choose a reason for hiding this comment

tnqn commented Mar 10, 2022

wenyingd commented Mar 11, 2022

ceclinux commented Mar 15, 2022

ceclinux commented Mar 16, 2022

wenyingd commented Mar 16, 2022

XinShuYang commented Mar 16, 2022

wenyingd commented Mar 16, 2022

wenyingd commented Mar 3, 2022 •

edited

Loading

codecov-commenter commented Mar 3, 2022 •

edited

Loading

wenyingd Mar 4, 2022 •

edited

Loading

ceclinux Mar 4, 2022 •

edited

Loading