Do not panic when processing a PacketIn message for a denied connection #3447
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the NetworkPolicy or rule cannot be found in the cache. I assume that this is ok, since the existing log message used for this scenario has such a high level (4). Signed-off-by: Antonin Bas <abas@vmware.com>
|
This is what I observed in the Agent logs during testing: |
Codecov Report
@@ Coverage Diff @@
## main #3447 +/- ##
==========================================
- Coverage 63.52% 53.77% -9.75%
==========================================
Files 268 374 +106
Lines 26900 41448 +14548
==========================================
+ Hits 17087 22287 +5200
- Misses 7951 16808 +8857
- Partials 1862 2353 +491
Flags with carried forward coverage won't be shown. Click here to find out more.
|
|
Thinking more about this, this issue is probably because of a separate bug. It's bad that we panic here, but we panic because the rule ID we extract from the PacketIn message is clearly invalid. As a reminder we allocate ids incrementally starting at 0, and 168428067 is way too high to make any sense. Looking at the rest of the logs, we only have installed 4 rules, with IDs 1,2,3 and 4. See #3448 |
Dyanngg
approved these changes
Mar 14, 2022
|
/test-all |
|
/test-e2e |
antoninbas
deleted the
do-not-panic-for-packetin-with-unknown-policy-or-rule-id
branch
Atish-iaf
pushed a commit
to Atish-iaf/antrea
that referenced
this pull request
Mar 17, 2022
…on (antrea-io#3447) If the NetworkPolicy or rule cannot be found in the cache. I assume that this is ok, since the existing log message used for this scenario has such a high level (4). [CI][e2e] Wait for Service to be realized in proxy tests Change the mechanism to wait for Service to be realized from sleep for a fixed length of time into poll to make sure that the Service has been realized. Fixes antrea-io#2275 Signed-off-by: Antonin Bas <abas@vmware.com> Signed-off-by: Kumar Atish <atish.iaf@gmail.com>
Atish-iaf
pushed a commit
to Atish-iaf/antrea
that referenced
this pull request
Mar 18, 2022
…on (antrea-io#3447) If the NetworkPolicy or rule cannot be found in the cache. I assume that this is ok, since the existing log message used for this scenario has such a high level (4). [CI][e2e] Wait for Service to be realized in proxy tests Changed the mechanism to wait for Service to be realized from sleep for a fixed length of time into poll to make sure that the Service has been realized. The testProxyHairpin was using nc to listen for TCP connections, and it exits immediately after one successful connection. So the Pod terminated after the waitForService tests. Maybe it is caused by the limitation of nc in busybox. To resolve this, busybox pod has been replaced with agnhost in testProxyHairpin. Fixes antrea-io#2275 Signed-off-by: Antonin Bas <abas@vmware.com> Signed-off-by: Kumar Atish <atish.iaf@gmail.com>
Atish-iaf
pushed a commit
to Atish-iaf/antrea
that referenced
this pull request
Mar 18, 2022
…on (antrea-io#3447) If the NetworkPolicy or rule cannot be found in the cache. I assume that this is ok, since the existing log message used for this scenario has such a high level (4). [CI][e2e] Wait for Service to be realized in proxy tests Changed the mechanism to wait for Service to be realized from sleep for a fixed length of time into poll to make sure that the Service has been realized. The testProxyHairpin was using nc to listen for TCP connections, and it exits immediately after one successful connection. So the Pod terminated after the waitForService tests. Maybe it is caused by the limitation of nc in busybox. To resolve this, busybox pod has been replaced with agnhost in testProxyHairpin. Fixes antrea-io#2275 Signed-off-by: Antonin Bas <abas@vmware.com> Signed-off-by: Kumar Atish <atish.iaf@gmail.com>
Atish-iaf
pushed a commit
to Atish-iaf/antrea
that referenced
this pull request
Mar 18, 2022
…on (antrea-io#3447) If the NetworkPolicy or rule cannot be found in the cache. I assume that this is ok, since the existing log message used for this scenario has such a high level (4). [CI][e2e] Wait for Service to be realized in proxy tests Changed the mechanism to wait for Service to be realized from sleep for a fixed length of time into poll to make sure that the Service has been realized. The testProxyHairpin was using nc to listen for TCP connections, and it exits immediately after one successful connection. So the Pod terminated after the waitForService tests. Maybe it is caused by the limitation of nc in busybox. To resolve this, busybox pod has been replaced with agnhost in testProxyHairpin. Fixes antrea-io#2275 Signed-off-by: Antonin Bas <abas@vmware.com> Signed-off-by: Kumar Atish <atish.iaf@gmail.com>
Atish-iaf
pushed a commit
to Atish-iaf/antrea
that referenced
this pull request
Mar 21, 2022
…on (antrea-io#3447) If the NetworkPolicy or rule cannot be found in the cache. I assume that this is ok, since the existing log message used for this scenario has such a high level (4). [CI][e2e] Wait for Service to be realized in proxy tests Changed the mechanism to wait for Service to be realized from sleep for a fixed length of time into poll to make sure that the Service has been realized. The testProxyHairpin was using nc to listen for TCP connections, and it exits immediately after one successful connection. So the Pod terminated after the waitForService tests. Maybe it is caused by the limitation of nc in busybox. To resolve this, busybox pod has been replaced with agnhost in testProxyHairpin. Fixes antrea-io#2275 Signed-off-by: Antonin Bas <abas@vmware.com> Signed-off-by: Kumar Atish <atish.iaf@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the NetworkPolicy or rule cannot be found in the cache.
I assume that this is ok, since the existing log message used for this
scenario has such a high level (4).
Signed-off-by: Antonin Bas abas@vmware.com