Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update OVS to 2.17.0 #3591

Merged
merged 1 commit into from
Apr 15, 2022
Merged

Conversation

antoninbas
Copy link
Contributor

There is no update that significantly impacts Antrea, now that we no
longer rely on the userspace datapath.

We also apply a patch that is available in the 'master' branch, but
hasn't been released yet. The patch fixes #2003.

Signed-off-by: Antonin Bas abas@vmware.com

There is no update that significantly impacts Antrea, now that we no
longer rely on the userspace datapath.

We also apply a patch that is available in the 'master' branch, but
hasn't been released yet. The patch fixes antrea-io#2003.

Signed-off-by: Antonin Bas <abas@vmware.com>
@antoninbas antoninbas added area/dependency Issues or PRs related to dependency changes. action/release-note Indicates a PR that should be included in release notes. labels Apr 6, 2022
@antoninbas antoninbas requested review from jianjuns, tnqn and wenyingd April 6, 2022 21:40
@codecov-commenter
Copy link

codecov-commenter commented Apr 6, 2022

Codecov Report

Merging #3591 (dad6d85) into main (7be763e) will decrease coverage by 13.84%.
The diff coverage is 53.30%.

❗ Current head dad6d85 differs from pull request most recent head 7237044. Consider uploading reports for the commit 7237044 to get more accurate results

Impacted file tree graph

@@             Coverage Diff             @@
##             main    #3591       +/-   ##
===========================================
- Coverage   64.16%   50.32%   -13.85%     
===========================================
  Files         278      248       -30     
  Lines       27825    35657     +7832     
===========================================
+ Hits        17854    17944       +90     
- Misses       8063    15920     +7857     
+ Partials     1908     1793      -115     
Flag Coverage Δ
e2e-tests 50.32% <53.30%> (?)
kind-e2e-tests ?
unit-tests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/agent/cniserver/pod_configuration.go 42.77% <0.00%> (-11.05%) ⬇️
pkg/agent/openflow/pipeline_other.go 4.00% <0.00%> (-1.13%) ⬇️
pkg/features/antrea_features.go 11.11% <ø> (+2.02%) ⬆️
pkg/agent/proxy/proxier.go 47.64% <3.70%> (-13.56%) ⬇️
pkg/agent/cniserver/ipam/antrea_ipam_controller.go 32.87% <46.96%> (-47.13%) ⬇️
pkg/ipam/poolallocator/allocator.go 30.36% <50.00%> (-19.27%) ⬇️
pkg/agent/cniserver/ipam/antrea_ipam.go 46.82% <50.96%> (-32.96%) ⬇️
pkg/agent/cniserver/server.go 41.41% <51.57%> (-24.36%) ⬇️
pkg/agent/controller/networkpolicy/reject.go 76.47% <55.00%> (-11.44%) ⬇️
pkg/agent/openflow/pipeline.go 69.35% <56.96%> (-4.77%) ⬇️
... and 284 more

@antoninbas
Copy link
Contributor Author

/test-all

@wenyingd
Copy link
Contributor

Hi, do you think we should also bump up Windows OVS version? @antoninbas @jianjuns @tnqn

@antoninbas
Copy link
Contributor Author

@wenyingd that would be good. If you have new binaries, you can upload them to our S3 bucket and submit a PR.

@antoninbas
Copy link
Contributor Author

/test-e2e

@antoninbas
Copy link
Contributor Author

/test-e2e
/test-integration

@antoninbas antoninbas merged commit ac49f47 into antrea-io:main Apr 15, 2022
@antoninbas antoninbas deleted the update-ovs-to-2.17 branch April 15, 2022 20:24
@hongliangl
Copy link
Contributor

hongliangl commented Apr 16, 2022

There is no update that significantly impacts Antrea, now that we no
longer rely on the userspace datapath.

Can we remove the code of userspace in openflow now like in this link @antoninbas

@antoninbas
Copy link
Contributor Author

There is no update that significantly impacts Antrea, now that we no
longer rely on the userspace datapath.

Can we remove the code of userspace in openflow now like in this link @antoninbas

I don't have a preference. We don't use that code at the moment, so we could remove it. There have been talks in the past of supporting ovs-dpdk for the primary Pod network, which would require that code. But if this support is needed, we can always add the code back. It is likely that since we no longer test with the userspace datapath anyway, this code path is already broken (or will be soon), so it may be a good idea to just remove it for now and simplify the code base.

hongliangl added a commit to hongliangl/antrea that referenced this pull request Apr 21, 2022
Since now we no longer rely on the userspace datapath as mentioned in antrea-io#3591, then
related code can be removed.

Signed-off-by: Hongliang Liu <lhongliang@vmware.com>
hongliangl added a commit to hongliangl/antrea that referenced this pull request Apr 21, 2022
Since now we no longer rely on the userspace datapath as mentioned in antrea-io#3591, then
related code can be removed.

Signed-off-by: Hongliang Liu <lhongliang@vmware.com>
hongliangl added a commit to hongliangl/antrea that referenced this pull request Apr 21, 2022
Since now we no longer rely on the userspace datapath as mentioned in antrea-io#3591, then
related code can be removed.

Signed-off-by: Hongliang Liu <lhongliang@vmware.com>
hongliangl added a commit to hongliangl/antrea that referenced this pull request Apr 23, 2022
Since now we no longer rely on the userspace datapath as mentioned in antrea-io#3591, then
related code can be removed.

Signed-off-by: Hongliang Liu <lhongliang@vmware.com>
hongliangl added a commit to hongliangl/antrea that referenced this pull request Apr 26, 2022
Since now we no longer rely on the userspace datapath as mentioned in antrea-io#3591, then
related code can be removed.

Signed-off-by: Hongliang Liu <lhongliang@vmware.com>
jianjuns pushed a commit that referenced this pull request Apr 27, 2022
Since now we no longer rely on the userspace datapath as mentioned in #3591, then
related code can be removed.

Signed-off-by: Hongliang Liu <lhongliang@vmware.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
action/release-note Indicates a PR that should be included in release notes. area/dependency Issues or PRs related to dependency changes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

OVS leak log file when rotating logs
6 participants