-
Notifications
You must be signed in to change notification settings - Fork 376
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Windows CI failures by updating image tags #4801
Conversation
/test-windows-all |
/test-windows-conformance |
/test-all |
/test-windows-containerd-networkpolicy |
@@ -394,8 +394,8 @@ function deliver_antrea_windows { | |||
revert_snapshot_windows ${WORKER_NAME} | |||
# Some tests need us.gcr.io/k8s-artifacts-prod/e2e-test-images/agnhost:2.13 image but it is not for windows/amd64 10.0.17763 | |||
# Use e2eteam/agnhost:2.13 instead | |||
harbor_images=("sigwindowstools-kube-proxy:v1.18.0" "agnhost:2.13" "agnhost:2.13" "agnhost:2.13" "agnhost:2.29" "e2eteam-jessie-dnsutils:1.0" "e2eteam-jessie-dnsutils:1.0" "e2eteam-pause:3.2" "e2eteam-pause:3.2" "e2eteam-busybox:1.29-windows-amd64-1809") | |||
antrea_images=("sigwindowstools/kube-proxy:v1.18.0" "e2eteam/agnhost:2.13" "us.gcr.io/k8s-artifacts-prod/e2e-test-images/agnhost:2.13" "k8sprow.azurecr.io/kubernetes-e2e-test-images/agnhost:2.13" "registry.k8s.io/e2e-test-images/agnhost:2.29" "e2eteam/jessie-dnsutils:1.0" "gcr.io/kubernetes-e2e-test-images/jessie-dnsutils:1.0" "e2eteam/pause:3.2" "registry.k8s.io/pause:3.2" "docker.io/library/busybox:1.29") | |||
harbor_images=("sigwindowstools-kube-proxy:v1.18.0" "agnhost:2.13" "agnhost:2.13" "agnhost:2.13" "agnhost:2.29" "agnhost:2.29" "e2eteam-jessie-dnsutils:1.0" "e2eteam-jessie-dnsutils:1.0" "e2eteam-pause:3.2" "e2eteam-pause:3.2" "e2eteam-pause:3.2" "e2eteam-busybox:1.29-windows-amd64-1809") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am a little confused about the duplicate image name, do we use this to keep the array length the same?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, but we can avoid using duplicate image name by new map structure. I will refactor the image pulling function.
/test-windows-containerd-networkpolicy |
1 similar comment
/test-windows-containerd-networkpolicy |
Add necessary image tags which was removed by (antrea-io#4720). For antrea-io#4704 Signed-off-by: Shuyang Xin <gavinx@vmware.com>
/test-windows-containerd-networkpolicy |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. I assume you will be doing the refactoring you mention in https://github.com/antrea-io/antrea/pull/4801/files#r1157398869 in another PR?
Yes , I think we need to recover the conformance test first. |
/test-windows-all |
/skip-all |
Add necessary image tags which was removed by (antrea-io#4720). For antrea-io#4704 Signed-off-by: Shuyang Xin <gavinx@vmware.com>
Add necessary image tags which was removed by (#4720).
For #4704