Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Windows CI failures by updating image tags #4801

Merged
merged 1 commit into from
Apr 6, 2023

Conversation

XinShuYang
Copy link
Contributor

Add necessary image tags which was removed by (#4720).

For #4704

@XinShuYang
Copy link
Contributor Author

/test-windows-all

@XinShuYang
Copy link
Contributor Author

/test-windows-conformance
/test-windows-containerd-networkpolicy

@XinShuYang
Copy link
Contributor Author

/test-all

@XinShuYang
Copy link
Contributor Author

/test-windows-containerd-networkpolicy

@@ -394,8 +394,8 @@ function deliver_antrea_windows {
revert_snapshot_windows ${WORKER_NAME}
# Some tests need us.gcr.io/k8s-artifacts-prod/e2e-test-images/agnhost:2.13 image but it is not for windows/amd64 10.0.17763
# Use e2eteam/agnhost:2.13 instead
harbor_images=("sigwindowstools-kube-proxy:v1.18.0" "agnhost:2.13" "agnhost:2.13" "agnhost:2.13" "agnhost:2.29" "e2eteam-jessie-dnsutils:1.0" "e2eteam-jessie-dnsutils:1.0" "e2eteam-pause:3.2" "e2eteam-pause:3.2" "e2eteam-busybox:1.29-windows-amd64-1809")
antrea_images=("sigwindowstools/kube-proxy:v1.18.0" "e2eteam/agnhost:2.13" "us.gcr.io/k8s-artifacts-prod/e2e-test-images/agnhost:2.13" "k8sprow.azurecr.io/kubernetes-e2e-test-images/agnhost:2.13" "registry.k8s.io/e2e-test-images/agnhost:2.29" "e2eteam/jessie-dnsutils:1.0" "gcr.io/kubernetes-e2e-test-images/jessie-dnsutils:1.0" "e2eteam/pause:3.2" "registry.k8s.io/pause:3.2" "docker.io/library/busybox:1.29")
harbor_images=("sigwindowstools-kube-proxy:v1.18.0" "agnhost:2.13" "agnhost:2.13" "agnhost:2.13" "agnhost:2.29" "agnhost:2.29" "e2eteam-jessie-dnsutils:1.0" "e2eteam-jessie-dnsutils:1.0" "e2eteam-pause:3.2" "e2eteam-pause:3.2" "e2eteam-pause:3.2" "e2eteam-busybox:1.29-windows-amd64-1809")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am a little confused about the duplicate image name, do we use this to keep the array length the same?

Copy link
Contributor Author

@XinShuYang XinShuYang Apr 4, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, but we can avoid using duplicate image name by new map structure. I will refactor the image pulling function.

@XinShuYang
Copy link
Contributor Author

/test-windows-containerd-networkpolicy

1 similar comment
@XinShuYang
Copy link
Contributor Author

/test-windows-containerd-networkpolicy

Add necessary image tags which was removed by (antrea-io#4720).

For antrea-io#4704

Signed-off-by: Shuyang Xin <gavinx@vmware.com>
@XinShuYang
Copy link
Contributor Author

/test-windows-containerd-networkpolicy

Copy link
Contributor

@antoninbas antoninbas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I assume you will be doing the refactoring you mention in https://github.com/antrea-io/antrea/pull/4801/files#r1157398869 in another PR?

@XinShuYang
Copy link
Contributor Author

LGTM. I assume you will be doing the refactoring you mention in https://github.com/antrea-io/antrea/pull/4801/files#r1157398869 in another PR?

Yes , I think we need to recover the conformance test first.

@XinShuYang
Copy link
Contributor Author

/test-windows-all

@tnqn
Copy link
Member

tnqn commented Apr 6, 2023

/skip-all

@tnqn tnqn merged commit 4ef8eec into antrea-io:main Apr 6, 2023
jainpulkit22 pushed a commit to urharshitha/antrea that referenced this pull request Apr 28, 2023
Add necessary image tags which was removed by (antrea-io#4720).

For antrea-io#4704

Signed-off-by: Shuyang Xin <gavinx@vmware.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants