Fix antrea-agent crashing with proxyAll enabled in networkPolicyOnly mode #6259
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hongliangl
added
action/release-note
|
Will add the commit message later. |
tnqn
reviewed
Apr 25, 2024
pkg/agent/route/route_linux.go
Outdated
| @@ -418,6 +420,7 @@ func (c *Client) syncIPSet() error { | |||
| } | |||
| } | |||
|
|
|||
| // Multicast is only available in encap mode. | |||
There was a problem hiding this comment.
This is also wrong. Multicast supports noEncap.
There was a problem hiding this comment.
@wenyingd , since Mutilcast supports both encap and noEncap, could you help verify the if the ipsets here should be synced in both encap and noEncap modes? Or the ipsets are only needed in encap mode?
There was a problem hiding this comment.
Got the answer from here
antrea/pkg/agent/route/route_linux.go
Line 1836 in 5c79f39
hongliangl
force-pushed
the
20240424-fix-proxyall-in-policy-only-mode
branch
from
4548f42
to
c81cd03
Compare
hongliangl
force-pushed
the
20240424-fix-proxyall-in-policy-only-mode
branch
from
c81cd03
to
8a93220
Compare
|
@tnqn Could you have another look at this PR? Thanks! |
|
@tnqn Could you help have another look at this? |
luolanzone
reviewed
May 29, 2024
…mode In networkPolicyOnly mode and proxyAll is enabled, the ifindex of antrea-gw0 in `nodeConfig` is uninitialized, resulting in the failure to install the ip neighbor to antrea-gw0 due to the fact that the ifindex of antrea-gw0 is wrong. Additionally, the ipsets storing the pairs of Node IP and NodePort are not initialized and periodically synced. Consequently, this results in the failure to sync the iptables rules that referring to the ipsets. Signed-off-by: Hongliang Liu <lhongliang@vmware.com>
hongliangl
force-pushed
the
20240424-fix-proxyall-in-policy-only-mode
branch
from
8a93220
to
de80443
Compare
|
/test-all |
hongliangl
added a commit
to hongliangl/antrea
that referenced
this pull request
Jun 6, 2024
…mode (antrea-io#6259) In networkPolicyOnly mode and proxyAll is enabled, the ifindex of antrea-gw0 in `nodeConfig` is uninitialized, resulting in the failure to install the ip neighbor to antrea-gw0 due to the fact that the ifindex of antrea-gw0 is wrong. Additionally, the ipsets storing the pairs of Node IP and NodePort are not initialized and periodically synced. Consequently, this results in the failure to sync the iptables rules that referring to the ipsets. Signed-off-by: Hongliang Liu <lhongliang@vmware.com>
hongliangl
added a commit
to hongliangl/antrea
that referenced
this pull request
Jun 6, 2024
…mode (antrea-io#6259) In networkPolicyOnly mode and proxyAll is enabled, the ifindex of antrea-gw0 in `nodeConfig` is uninitialized, resulting in the failure to install the ip neighbor to antrea-gw0 due to the fact that the ifindex of antrea-gw0 is wrong. Additionally, the ipsets storing the pairs of Node IP and NodePort are not initialized and periodically synced. Consequently, this results in the failure to sync the iptables rules that referring to the ipsets. Signed-off-by: Hongliang Liu <lhongliang@vmware.com>
hongliangl
added a commit
to hongliangl/antrea
that referenced
this pull request
Jun 6, 2024
…mode (antrea-io#6259) In networkPolicyOnly mode and proxyAll is enabled, the ifindex of antrea-gw0 in `nodeConfig` is uninitialized, resulting in the failure to install the ip neighbor to antrea-gw0 due to the fact that the ifindex of antrea-gw0 is wrong. Additionally, the ipsets storing the pairs of Node IP and NodePort are not initialized and periodically synced. Consequently, this results in the failure to sync the iptables rules that referring to the ipsets. Signed-off-by: Hongliang Liu <lhongliang@vmware.com>
tnqn
pushed a commit
that referenced
this pull request
Jun 6, 2024
…mode (#6259) (#6410) In networkPolicyOnly mode and proxyAll is enabled, the ifindex of antrea-gw0 in `nodeConfig` is uninitialized, resulting in the failure to install the ip neighbor to antrea-gw0 due to the fact that the ifindex of antrea-gw0 is wrong. Additionally, the ipsets storing the pairs of Node IP and NodePort are not initialized and periodically synced. Consequently, this results in the failure to sync the iptables rules that referring to the ipsets. Signed-off-by: Hongliang Liu <lhongliang@vmware.com>
tnqn
pushed a commit
that referenced
this pull request
Jun 6, 2024
…mode (#6259) (#6408) In networkPolicyOnly mode and proxyAll is enabled, the ifindex of antrea-gw0 in `nodeConfig` is uninitialized, resulting in the failure to install the ip neighbor to antrea-gw0 due to the fact that the ifindex of antrea-gw0 is wrong. Additionally, the ipsets storing the pairs of Node IP and NodePort are not initialized and periodically synced. Consequently, this results in the failure to sync the iptables rules that referring to the ipsets. Signed-off-by: Hongliang Liu <lhongliang@vmware.com>
tnqn
pushed a commit
that referenced
this pull request
Jun 6, 2024
…mode (#6259) (#6409) In networkPolicyOnly mode and proxyAll is enabled, the ifindex of antrea-gw0 in `nodeConfig` is uninitialized, resulting in the failure to install the ip neighbor to antrea-gw0 due to the fact that the ifindex of antrea-gw0 is wrong. Additionally, the ipsets storing the pairs of Node IP and NodePort are not initialized and periodically synced. Consequently, this results in the failure to sync the iptables rules that referring to the ipsets. Signed-off-by: Hongliang Liu <lhongliang@vmware.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In networkPolicyOnly mode and proxyAll is enabled, the ifindex of antrea-gw0 in
nodeConfigis uninitialized, resulting in the failure to install the ip neighbor to antrea-gw0 due to
the fact that the ifindex of antrea-gw0 is wrong. Additionally, the ipsets storing the pairs
of Node IP and NodePort are not initialized and periodically synced. Consequently, this results
in the failure to sync the iptables rules that referring to the ipsets.