-
Notifications
You must be signed in to change notification settings - Fork 367
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added the new antctl check command documentation #6373
Conversation
Signed-off-by: Kanha gupta <kanhag4163@gmail.com>
Signed-off-by: Kanha gupta <kanhag4163@gmail.com>
Please review. changes have been pushed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Only nits from me. Overall it looks good.
Maybe it's a bit early for this now, but as we keep improving this tool it may make sense to add a reference to it in getting-started.md
Can we add reference with a beta tag on it ? I believe that even its early, It would be very helpful while setup |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
I think it's better to wait for a release before updating getting-started.md. Let's keep adding a few more tests and keep on enhancing the tool. We will mention the new commands in the release notes for Antrea v2.1 though. |
Added documentation for the new
antctl check
command.