Exclude terminated Pods from group members #6508
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tnqn
added
action/backport
jianjuns
reviewed
Jul 5, 2024
pkg/util/k8s/pod.go
Outdated
|
|
||
| import v1 "k8s.io/api/core/v1" | ||
|
|
||
| func IsPodTerminal(pod *v1.Pod) bool { |
There was a problem hiding this comment.
I saw this function name in kubernetes several times, e.g. https://github.com/kubernetes/kubernetes/blob/release-1.30/staging/src/k8s.io/endpointslice/util/controller_utils.go#L95-L98.
I just found there is a public util function IsPodTerminal in "k8s.io/kubernetes/pkg/api/v1/pod" and changed to use it.
There was a problem hiding this comment.
Just realized this is in an internal package of kubernetes, so still have to define our own one.
pkg/controller/egress/controller.go
Outdated
| @@ -371,9 +372,9 @@ func (c *EgressController) syncEgress(key string) error { | |||
| egressGroup := egressGroupObj.(*antreatypes.EgressGroup) | |||
| pods, _ := c.groupingInterface.GetEntities(egressGroupType, key) | |||
| for _, pod := range pods { | |||
| // Ignore Pod if it's not scheduled or not running. And Egress does not support HostNetwork Pods, so also ignore | |||
| // Ignore Pod if it's not scheduled or is already terminal. And Egress does not support HostNetwork Pods, so also ignore | |||
When calculating AddressGroups, terminated Pods should be excluded because their IPs can be recycled and reused by other active Pods. When calculating AppliedToGroups and EgressGroups, terminated Pods could be excluded as their network resources including network interfaces have been deleted. Signed-off-by: Quan Tian <quan.tian@broadcom.com>
tnqn
changed the title
|
/test-all |
jianjuns
approved these changes
Jul 8, 2024
|
/test-all |
Dyanngg
approved these changes
Jul 9, 2024
tnqn
added a commit
to tnqn/antrea
that referenced
this pull request
Jul 9, 2024
When calculating AddressGroups, terminated Pods should be excluded because their IPs can be recycled and reused by other active Pods. When calculating AppliedToGroups and EgressGroups, terminated Pods could be excluded as their network resources including network interfaces have been deleted. Signed-off-by: Quan Tian <quan.tian@broadcom.com>
tnqn
added a commit
to tnqn/antrea
that referenced
this pull request
Jul 9, 2024
When calculating AddressGroups, terminated Pods should be excluded because their IPs can be recycled and reused by other active Pods. When calculating AppliedToGroups and EgressGroups, terminated Pods could be excluded as their network resources including network interfaces have been deleted. Signed-off-by: Quan Tian <quan.tian@broadcom.com>
tnqn
added a commit
that referenced
this pull request
Jul 10, 2024
When calculating AddressGroups, terminated Pods should be excluded because their IPs can be recycled and reused by other active Pods. When calculating AppliedToGroups and EgressGroups, terminated Pods could be excluded as their network resources including network interfaces have been deleted. Signed-off-by: Quan Tian <quan.tian@broadcom.com>
tnqn
added a commit
that referenced
this pull request
Jul 10, 2024
When calculating AddressGroups, terminated Pods should be excluded because their IPs can be recycled and reused by other active Pods. When calculating AppliedToGroups and EgressGroups, terminated Pods could be excluded as their network resources including network interfaces have been deleted. Signed-off-by: Quan Tian <quan.tian@broadcom.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When calculating AddressGroups, terminated Pods should be excluded because their IPs can be recycled and reused by other active Pods.
When calculating AppliedToGroups and EgressGroups, terminated Pods could be excluded as their network resources including network interfaces have been deleted.
Fixes #6507