-
Notifications
You must be signed in to change notification settings - Fork 387
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FlowAggregator] Add clusterId to aggregated records #6769
Conversation
49d1dcc
to
0c3d2d8
Compare
Will it introduce fields redundancy for s3uploader and clickhouseexporter? as we previously added the field through #4214? Is it the same thing? |
If you mean redundancy, as we are adding information we don't need for these exporters, then the answer is yes. These exporters add the field directly to their output, and they don't need this information. There is no straightforward solution to improve this IMO, as the IPFIX exporter cannot modify records, so it has to be done at "aggregation" time. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
In order to allow external flow collectors to easily identify which cluster the record is coming from (rather than relying on the observationDomainId or the exporter's IP address). We use the cluster UUID (generated by Antrea) to populate this IE. Signed-off-by: Antonin Bas <antonin.bas@broadcom.com>
Signed-off-by: Antonin Bas <antonin.bas@broadcom.com>
Signed-off-by: Antonin Bas <antonin.bas@broadcom.com>
0c3d2d8
to
bfef953
Compare
/test-all |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
In order to allow external flow collectors to easily identify which cluster the record is coming from (rather than relying on the observationDomainId or the exporter's IP address).
We use the cluster UUID (generated by Antrea) to populate this IE.