Support /test-whole-conformance and daily job #826
Conversation
|
Thanks for your PR. The following commands are available:
These commands can only be run by members of the vmware-tanzu organization. |
ci/jenkins/jobs/macros.yaml
Outdated
| @@ -171,7 +171,7 @@ | |||
|
|
|||
| rm -f COMMENT_EXIST | |||
| rm -f body.json | |||
| echo "{{\"body\": \"Thanks for your PR.\\\nUnit tests and code linters are run automatically every time the PR is updated.\\\nE2e, conformance and network policy tests can only be triggered by a member of the vmware-tanzu organization. Regular contributors to the project should join the org.\\\n\\\nThe following commands are available:\\\n* \`/test-e2e\`: to trigger e2e tests.\\\n* \`/skip-e2e\`: to skip e2e tests.\\\n* \`/test-conformance\`: to trigger conformance tests.\\\n* \`/skip-conformance\`: to skip conformance tests.\\\n* \`/test-networkpolicy\`: to trigger networkpolicy tests.\\\n* \`/skip-networkpolicy\`: to skip networkpolicy tests.\\\n* \`/test-windows-conformance\`: to trigger windows conformance tests.\\\n* \`/skip-windows-conformance\`: to skip windows conformance tests.\\\n* \`/test-all\`: to trigger all tests.\\\n* \`/skip-all\`: to skip all tests.\\\n\\\nThese commands can only be run by members of the vmware-tanzu organization.\"}}" > body.json | |||
| echo "{{\"body\": \"Thanks for your PR.\\\nUnit tests and code linters are run automatically every time the PR is updated.\\\nE2e, conformance and network policy tests can only be triggered by a member of the vmware-tanzu organization. Regular contributors to the project should join the org.\\\n\\\nThe following commands are available:\\\n* \`/test-e2e\`: to trigger e2e tests.\\\n* \`/skip-e2e\`: to skip e2e tests.\\\n* \`/test-conformance\`: to trigger conformance tests.\\\n* \`/skip-conformance\`: to skip conformance tests.\\\n* \`/test-conformance\`: to trigger all conformance tests on linux.\\\n* \`/test-networkpolicy\`: to trigger networkpolicy tests.\\\n* \`/skip-networkpolicy\`: to skip networkpolicy tests.\\\n* \`/test-windows-conformance\`: to trigger windows conformance tests.\\\n* \`/skip-windows-conformance\`: to skip windows conformance tests.\\\n* \`/test-all\`: to trigger all tests.\\\n* \`/skip-all\`: to skip all tests.\\\n\\\nThese commands can only be run by members of the vmware-tanzu organization.\"}}" > body.json | |||
There was a problem hiding this comment.
this says that both commands are named the same (/test-conformance)?
There was a problem hiding this comment.
Thanks for reminding. Updated.
| only_trigger_phrase: false | ||
| trigger_permit_all: true | ||
| status_context: jenkins-whole-conformance | ||
| status_url: --none-- |
There was a problem hiding this comment.
what's the difference between --none-- and null?
There was a problem hiding this comment.
null applies to e2e, conformance.. so Jenkins will automatically put a link to the build.
--none-- means there's no link.
ci/jenkins/jobs/projects.yaml
Outdated
| success_status: Pending test. Mark as failure. Add comment /test-whole-conformance to trigger. | ||
| failure_status: Pending test. Mark as failure. Add comment /test-whole-conformance to trigger. | ||
| error_status: Pending test. Mark as failure. Add comment /test-whole-conformance to trigger. |
There was a problem hiding this comment.
I think we should make it clear that running these tests is not required for the PR to be merged?
There was a problem hiding this comment.
It makes sense. Updated.
|
/test-windows-conformance |
2 similar comments
|
/test-windows-conformance |
|
/test-windows-conformance |
ci/jenkins/jobs/projects.yaml
Outdated
| success_status: Pending test. Mark as failure. Check not required. Add comment /test-whole-conformance to trigger. | ||
| failure_status: Pending test. Mark as failure. Check not required. Add comment /test-whole-conformance to trigger. | ||
| error_status: Pending test. Mark as failure. Check not required. Add comment /test-whole-conformance to trigger. |
There was a problem hiding this comment.
maybe replace "Check not required" with "Not required for merging"?
ci/jenkins/jobs/projects.yaml
Outdated
| failure_status: Failed. Check not required. Add comment /test-whole-conformance to re-trigger. | ||
| error_status: Failed. Check not required. Add comment /test-whole-conformance to re-trigger. |
There was a problem hiding this comment.
I think we can remove the explicit "Check not required" here. If someone decided to run the test and it failed, then it probably needs to be addressed, even if we do not actually block the PR.
There was a problem hiding this comment.
Yes, it makes sense. Updated.
lzhecheng
force-pushed
the
daily-job
branch
3 times, most recently
from
a0794e7
to
ac08358
Compare
lzhecheng
changed the title
|
Looks good to me. |
|
By the way, did you test that it can successfully send out email? |
I tried it on a test job and it worked. |
* Support /test-whole-conformance to trigger a whole conformance test * Support daily whole conformance test * If whole conformance test fails, Jenkins will send an email to projectantrea-dev@googlegroups.com Fixed issue antrea-io#819
|
Looks OK to me. |
|
/skip-all |
* Support /test-whole-conformance to trigger a whole conformance test * Support daily whole conformance test * If whole conformance test fails, Jenkins will send an email to projectantrea-dev@googlegroups.com Fixed issue antrea-io#819
Fixed issue #819
The timeout for whole conformance test is 2 hr.