Update Go version to v1.21 #303
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
reachjainrahul
force-pushed
the
goversion
branch
from
2cfd98b
to
d79e0f8
Compare
|
/nephe-test-e2e-kind |
Change build image to golang v1.21 Remove rand.Seed Update jenkins to install golang v1.21 Signed-off-by: Rahul Jain <rahulj@vmware.com>
reachjainrahul
force-pushed
the
goversion
branch
from
d79e0f8
to
01e01aa
Compare
|
/nephe-test-e2e-kind |
shenmo3
approved these changes
Aug 23, 2023
|
The CONTRIBUTING.md document still has a reference to Go 1.17 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Update Nephe to use golang v1.21
Changes
Changed build image to golang v1.21
Remove rand.Seed. Starting with Go v1.20, the generator is seeded randomly at program startup, and we no longer need to do it manually.
Update CI to install golang v1.21 on Jenkins node