Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add adjust & scale #1626

Merged
merged 2 commits into from
Oct 31, 2022
Merged

feat: add adjust & scale #1626

merged 2 commits into from
Oct 31, 2022

Conversation

tangying1027
Copy link
Contributor

Checklist
  • npm test passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines
Description of change

accesslint[bot]
accesslint bot reviewed Oct 21, 2022
View reviewed changes
Copy link

@accesslint accesslint bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are accessibility issues in these changes.

packages/adjust/README.md Outdated

> Data `adjust` for @antv/G2.

[![](https://img.shields.io/travis/antvis/adjust.svg)](https://travis-ci.org/antvis/adjust)
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This image is missing a text alternative. This is a problem for people using screen readers.

packages/adjust/README.md Outdated Show resolved Hide resolved
packages/adjust/README.md Outdated

[![](https://img.shields.io/travis/antvis/adjust.svg)](https://travis-ci.org/antvis/adjust)
![](https://img.shields.io/badge/language-javascript-red.svg)
![](https://img.shields.io/badge/license-MIT-000000.svg)
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This image is missing a text alternative. This is a problem for people using screen readers.

@lgtm-com
Copy link

lgtm-com bot commented Oct 21, 2022

This pull request introduces 6 alerts when merging 59cddc6 into 9232d8e - view on LGTM.com

new alerts:

  • 4 for Unused variable, import, function or class
  • 1 for Useless assignment to local variable
  • 1 for Ineffective parameter type

accesslint[bot]
accesslint bot reviewed Oct 31, 2022
View reviewed changes
Copy link

@accesslint accesslint bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏 You fixed the issue(s)! Great work.

@lgtm-com
Copy link

lgtm-com bot commented Oct 31, 2022

This pull request introduces 6 alerts when merging 6eb85b0 into 9232d8e - view on LGTM.com

new alerts:

  • 4 for Unused variable, import, function or class
  • 1 for Useless assignment to local variable
  • 1 for Ineffective parameter type

@tangying1027 tangying1027 merged commit 44cb0ef into v5.0.x Oct 31, 2022
@tangying1027 tangying1027 deleted the feat/add_adjust branch October 31, 2022 09:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@accesslint accesslint[bot] accesslint[bot] left review comments

@zengyue zengyue Awaiting requested review from zengyue

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@tangying1027