Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: 优化 withGuide ts 定义 #1934

Merged
merged 4 commits into from
Mar 6, 2024
Merged

feat: 优化 withGuide ts 定义 #1934

merged 4 commits into from
Mar 6, 2024

Conversation

El-Chiang
Copy link
Contributor

Checklist
  • npm test passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines
Description of change

@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 4, 2024 •
edited
Loading

Fails
🚫

node failed.

Log

Error:  ReferenceError: Cannot access 'artifact' before initialization
    at dangerfile.js:29:9
    at processTicksAndRejections (node:internal/process/task_queues:96:5)
danger-results://tmp/danger-results-875849ae.json

Generated by 🚫 dangerJS against 163f6c1

zengyue
zengyue reviewed Mar 4, 2024
View reviewed changes
site/.dumirc.ts Outdated
},
link: `/tutorial/getting-started`,
link: `/examples`,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

怎么会有这些改动？

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这个不是我改的，是官网模版升级自动变更

Copy link
Member

@zengyue zengyue Mar 4, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

我看了下应该是以前官网升级的改动，rebase 下 master 应该就可以了

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

去掉了

@El-Chiang El-Chiang requested a review from zengyue March 6, 2024 06:16
@zengyue zengyue merged commit 623b416 into master Mar 6, 2024
5 of 10 checks passed
@zengyue zengyue deleted the buli/feat/withGuide branch March 6, 2024 06:53
zengyue pushed a commit that referenced this pull request Mar 6, 2024
@El-Chiang @ai-qing-hai @zengyue
fix: 优化 withGuide ts 定义 (#1934)
524b506 
* chore: update dumi-theme-antv (#1890)

* feat: 优化 withGuide ts 类型

* fix: 修复 ts 类型错误

* Revert "chore: update dumi-theme-antv (#1890)"

This reverts commit 450be5a.

---------

Co-authored-by: Frank William <65594180+ai-qing-hai@users.noreply.github.com>
Co-authored-by: 不狸 <junyu.junyujiang@alibaba-inc.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tangying1027 tangying1027 Awaiting requested review from tangying1027

@zengyue zengyue Awaiting requested review from zengyue

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@El-Chiang @zengyue @ai-qing-hai