fix: when image src is an image instance, rendering will not be trigg…

…ered by default (#1827)
antvis · Nov 11, 2024 · 92b43d1 · 92b43d1
1 parent 57fd6ac
commit 92b43d1
Show file tree

Hide file tree

Showing 2 changed files with 17 additions and 14 deletions.
diff --git a/.changeset/purple-suns-retire.md b/.changeset/purple-suns-retire.md
@@ -0,0 +1,5 @@
+---
+'@antv/g-plugin-image-loader': patch
+---
+
+fix: when image src is an image instance, rendering will not be triggered by default
diff --git a/packages/g-plugin-image-loader/src/LoadImagePlugin.ts b/packages/g-plugin-image-loader/src/LoadImagePlugin.ts
@@ -36,21 +36,19 @@ export class LoadImagePlugin implements RenderingPlugin {
       if (nodeName === Shape.IMAGE) {
         const { src, keepAspectRatio } = attributes;
 
-        if (isString(src)) {
-          imagePool.getImageSync(
-            src,
-            object as DisplayObject,
-            ({ img: { width, height } }) => {
-              if (keepAspectRatio) {
-                calculateWithAspectRatio(object, width, height);
-              }
+        imagePool.getImageSync(
+          src,
+          object as DisplayObject,
+          ({ img: { width, height } }) => {
+            if (keepAspectRatio) {
+              calculateWithAspectRatio(object, width, height);
+            }
 
-              // set dirty rectangle flag
-              object.renderable.dirty = true;
-              renderingService.dirtify();
-            },
-          );
-        }
+            // set dirty rectangle flag
+            object.renderable.dirty = true;
+            renderingService.dirtify();
+          },
+        );
       }
     };