fix: webgl renderer has logical exception when updating attributes (#1768) #1769
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Aarebecca
approved these changes
Sep 9, 2024
14 tasks
wang1212
added a commit
that referenced
this pull request
Sep 14, 2024
* fix: `sourcemap.sources` path wrong (#1766) * fix: webgl renderer has logical exception when updating attributes (#1768) (#1769) * feat: added support for picking rotated text (#1749) (#1772) * chore: updated benchmark screenshots (#1773) * chore: updated benchmark screenshots * fix: sourcemap generation exception * chore: update test ci node version * chore: update screenshots and ci config * chore: delete redundant benchmark images * Version Packages (#1770) Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> --------- Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…1768)
🤔 This is a ...
🔗 Related issue link
fixed #1768
💡 Background and solution
see #1768
Reinitializing the geometry instance associated with the draw call instance with the latest element instance list before updating the attributes ensures correct rendering logic. And add boundary condition judgment.
📝 Changelog
☑️ Self Check before Merge