Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(g-canvas): should render when localRefresh change from false to true #423

Merged
merged 1 commit into from
Feb 25, 2020
Merged

fix(g-canvas): should render when localRefresh change from false to true #423

merged 1 commit into from
Feb 25, 2020

Conversation

dengfuping
Copy link
Member

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / Document optimization
  • TypeScript definition update
  • Refactoring
  • Performance improvement
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

💡 Background and solution

  • 问题原因: localRefresh: false 为全局渲染，不会记录要更新的元素队列 refreshElements。但如果将 localRefresh 同步修改为 true 时，实际采用的却是局部渲染的逻辑，但之前又没有记录 refreshElements，因此局部渲染的刷新区域为空，导致实际不会渲染。
  • 解决方案: 全局渲染模式下也需要记录更新的元素队列 refreshElements，渲染完成后同样需要置空。

📝 Changelog

Language Changelog
🇺🇸 English 🐞 [g-canvas] Fix no rendering when localRefresh change from false to true. #422
🇨🇳 Chinese 🐞 [g-canvas] 修复渲染模式从全局渲染切换到局部渲染时，渲染结果不生效的问题。#422

☑️ Self Check before Merge

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

@auto-add-label auto-add-label bot added the bug label Feb 25, 2020
tests-checker[bot]
tests-checker bot suggested changes Feb 25, 2020
View reviewed changes
Copy link

@tests-checker tests-checker bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please add tests to make sure this change works as expected?

@netlify
Copy link

netlify bot commented Feb 25, 2020 •
edited
Loading

Deploy preview for antv-g ready!

Built with commit e7f099e

https://deploy-preview-423--antv-g.netlify.com

@dengfuping dengfuping merged commit 39e2d35 into master Feb 25, 2020
@dengfuping dengfuping deleted the fix-issue-422 branch February 25, 2020 10:58
@pr-triage pr-triage bot added the PR: merged label Feb 25, 2020
openwayne pushed a commit to openwayne/g that referenced this pull request Jan 18, 2021
@dengfuping
Merge pull request antvis#423 from antvis/fix-issue-422
581a001 
fix(g-canvas): should render when localRefresh change from false to true
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tests-checker tests-checker[bot] tests-checker[bot] requested changes

Assignees
No one assigned
Labels
bug PR: merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Canvas] No rendering when localRefresh change from false to true
1 participant
@dengfuping