Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(g-base): delay should not work in toAttrs #427

Merged
merged 1 commit into from
Feb 26, 2020
Merged

Conversation

dengfuping
Copy link
Member

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / Document optimization
  • TypeScript definition update
  • Refactoring
  • Performance improvement
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

💡 Background and solution

-toAttrs.delay 不应该生效,原先 3.x 也不支持这种写法,因此 4.0 也不需要兼容。

📝 Changelog

Language Changelog
🇺🇸 English
🇨🇳 Chinese

☑️ Self Check before Merge

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

@auto-add-label auto-add-label bot added the bug label Feb 26, 2020
Copy link

@tests-checker tests-checker bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please add tests to make sure this change works as expected?

@netlify
Copy link

netlify bot commented Feb 26, 2020

Deploy preview for antv-g ready!

Built with commit c7f33fe

https://deploy-preview-427--antv-g.netlify.com

@dengfuping dengfuping merged commit e4effb3 into master Feb 26, 2020
@dengfuping dengfuping deleted the fix-pr-424 branch February 26, 2020 10:13
@pr-triage pr-triage bot added the PR: merged label Feb 26, 2020
openwayne pushed a commit to openwayne/g that referenced this pull request Jan 18, 2021
fix(g-base): delay should not work in toAttrs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant