Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(g-base): 补充 ShapeAttrs 类型定义 #440

Merged
merged 1 commit into from
Mar 12, 2020
Merged

feat(g-base): 补充 ShapeAttrs 类型定义 #440

merged 1 commit into from
Mar 12, 2020

Conversation

simaQ
Copy link
Contributor

@simaQ simaQ commented Mar 10, 2020

No description provided.

@simaQ simaQ requested review from dxq613 and dengfuping March 10, 2020 08:42
tests-checker[bot]
tests-checker bot suggested changes Mar 10, 2020
View reviewed changes
Copy link

@tests-checker tests-checker bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please add tests to make sure this change works as expected?

@dengfuping dengfuping merged commit 8bd9913 into master Mar 12, 2020
@dengfuping dengfuping deleted the shapeAttrs branch March 12, 2020 13:41
openwayne pushed a commit to openwayne/g that referenced this pull request Jan 18, 2021
@dengfuping
Merge pull request antvis#440 from antvis/shapeAttrs
7b5875d 
feat(g-base): 补充 ShapeAttrs 类型定义
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tests-checker tests-checker[bot] tests-checker[bot] requested changes

@dxq613 dxq613 Awaiting requested review from dxq613

@dengfuping dengfuping Awaiting requested review from dengfuping

Assignees
No one assigned
Labels
enhancement PR: merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@simaQ @dengfuping